Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: media/blink/webcontentdecryptionmodulesession_impl.h

Issue 2484873002: EME: Make sure sessions are closed before they are destroyed (Closed)
Patch Set: changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/blink/webcontentdecryptionmodulesession_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webcontentdecryptionmodulesession_impl.h
diff --git a/media/blink/webcontentdecryptionmodulesession_impl.h b/media/blink/webcontentdecryptionmodulesession_impl.h
index 18db47265a4c1cb093b59daf4893c4bbd2f34c3e..6824e6cc01eac1d1cf43377f13b05d3e0b8de6bb 100644
--- a/media/blink/webcontentdecryptionmodulesession_impl.h
+++ b/media/blink/webcontentdecryptionmodulesession_impl.h
@@ -75,9 +75,14 @@ class WebContentDecryptionModuleSessionImpl
// promise.
std::string session_id_;
- // Don't pass more than 1 close() event to blink::
- // TODO(jrummell): Remove this once blink tests handle close() promise and
- // closed() event.
+ // Keep track of whether the session has been closed or not. The session
+ // may be closed as a result of an application calling close(), or the CDM
+ // may close the session at any point.
+ // https://w3c.github.io/encrypted-media/#session-closed
+ // |has_close_been_called_| is used to keep track of whether close() has
+ // been called or not. |is_closed_| is used to keep track of whether the
+ // close event has been received or not.
+ bool has_close_been_called_;
bool is_closed_;
base::ThreadChecker thread_checker_;
« no previous file with comments | « no previous file | media/blink/webcontentdecryptionmodulesession_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698