Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2484863010: Fix QuicTest.java assertion on protocol string (Closed)

Created:
4 years, 1 month ago by xunjieli
Modified:
4 years, 1 month ago
Reviewers:
kapishnikov
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix QuicTest.java assertion on protocol string QUIC protocol string has changed in https://codereview.chromium.org/2461683002. This CL updates expectations. R=kapishnikov@chromium.org BUG=663780 Committed: https://crrev.com/afd11b9a1533fd51f690f544bfa879e9a4e15f93 Cr-Commit-Position: refs/heads/master@{#430968}

Patch Set 1 : self review #

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java View 1 7 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
xunjieli
4 years, 1 month ago (2016-11-09 17:33:47 UTC) #5
xunjieli
Done. PTAL.
4 years, 1 month ago (2016-11-09 17:40:45 UTC) #7
kapishnikov
lgtm
4 years, 1 month ago (2016-11-09 17:42:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484863010/40001
4 years, 1 month ago (2016-11-09 17:44:25 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-11-09 17:53:06 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 18:02:56 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/afd11b9a1533fd51f690f544bfa879e9a4e15f93
Cr-Commit-Position: refs/heads/master@{#430968}

Powered by Google App Engine
This is Rietveld 408576698