Make updateStyleAndLayoutTree ready for async stylesheet update.

Make updateStyleAndLayoutTree ready for async stylesheet update.

Introduce Document::updateActiveStyle() and corresponding
updateActiveStyle()/updateActiveStyleSheets() methods in StyleEngine to
prepare for doing active stylesheet updates as part of
updateStyleAndLayoutTree.

We move updateViewport() to updateActiveStyle() as the first step. This
is done by removing the synchronous calls to ViewportStyleResolver::
updateViewport() and instead schedule a layout tree update. In order to
trigger actual work to be done when the layout tree update happens, we
need to return true from Document::needsFullLayoutTreeUpdate() when we
need an active style update (for viewport atm).

BUG=567021
Committed: https://crrev.com/b50a2f4a9fe9733ed204f55f83a2e32727ba003d
Cr-Commit-Position: refs/heads/master@{#432182}

[rune, 2016-11-07 22:32:11]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 22:33:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 00:14:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 00:14:55]

Dry run: This issue passed the CQ dry run.

[rune, 2016-11-08 00:48:03]

rune@opera.com changed reviewers:
+ esprehn@chromium.org, meade@chromium.org

[rune, 2016-11-08 00:48:03]

ptal

[rune, 2016-11-08 14:03:00]

rune@opera.com changed reviewers:
+ timloh@chromium.org

[meade_UTC10, 2016-11-14 17:51:37]

lgtm

[rune, 2016-11-15 09:50:17]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-11-15 09:50:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 10:58:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 10:58:56]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rune, 2016-11-15 12:02:49]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-11-15 12:02:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 13:09:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 13:09:16]

Failed to apply patch for third_party/WebKit/Source/core/dom/Document.cpp:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/Source/core/dom/Document.cpp:1566
  error: third_party/WebKit/Source/core/dom/Document.cpp: patch does not apply

Patch:       third_party/WebKit/Source/core/dom/Document.cpp
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp
b/third_party/WebKit/Source/core/dom/Document.cpp
index
d1a185e5527a3c99ea73004ace5e1bb2bd12e6ec..5b7a8747df97e90e7abe6b73d977c45a2dd3421a
100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -605,11 +605,11 @@ void Document::setDoctype(DocumentType* docType) {
   if (m_docType) {
     this->adoptIfNeeded(*m_docType);
     if (m_docType->publicId().startsWith("-//wapforum//dtd xhtml mobile 1.",
-                                         TextCaseInsensitive))
+                                         TextCaseInsensitive)) {
       m_isMobileDocument = true;
+      m_styleEngine->viewportRulesChanged();
+    }
   }
-  // Doctype affects the interpretation of the stylesheets.
-  styleEngine().clearResolver();
 }
 
 DOMImplementation& Document::implementation() {
@@ -1566,6 +1566,8 @@ bool Document::needsLayoutTreeUpdate() const {
 bool Document::needsFullLayoutTreeUpdate() const {
   if (!isActive() || !view())
     return false;
+  if (m_styleEngine->needsActiveStyleUpdate())
+    return true;
   if (!m_useElementsNeedingUpdate.isEmpty())
     return true;
   if (!m_layerUpdateSVGFilterElements.isEmpty())
@@ -1620,10 +1622,9 @@ bool Document::hasPendingForcedStyleRecalc() const {
 }
 
 void Document::updateStyleInvalidationIfNeeded() {
+  DCHECK(isActive());
   ScriptForbiddenScope forbidScript;
 
-  if (!isActive())
-    return;
   if (!childNeedsStyleInvalidation())
     return;
   TRACE_EVENT0("blink", "Document::updateStyleInvalidationIfNeeded");
@@ -1876,6 +1877,7 @@ void Document::updateStyleAndLayoutTree() {
   evaluateMediaQueryListIfNeeded();
   updateUseShadowTreesIfNeeded();
   updateDistribution();
+  updateActiveStyle();
   updateStyleInvalidationIfNeeded();
 
   // FIXME: We should update style on our ancestor chain before proceeding
@@ -1917,6 +1919,13 @@ void Document::updateStyleAndLayoutTree() {
   InspectorInstrumentation::didRecalculateStyle(this);
 }
 
+void Document::updateActiveStyle() {
+  DCHECK(isActive());
+  DCHECK(isMainThread());
+  TRACE_EVENT0("blink", "Document::updateActiveStyle");
+  styleEngine().updateActiveStyle();
+}
+
 void Document::updateStyle() {
   DCHECK(!view()->shouldThrottleRendering());
   TRACE_EVENT_BEGIN0("blink,blink_style", "Document::updateStyle");

[rune, 2016-11-15 13:33:58]

The CQ bit was checked by rune@opera.com

[rune, 2016-11-15 13:33:58]

The patchset sent to the CQ was uploaded after l-g-t-m from meade@chromium.org
Link to the patchset: https://codereview.chromium.org/2484863003/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2016-11-15 13:34:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 15:25:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-15 15:28:32]

Description was changed from

==========
Make updateStyleAndLayoutTree ready for async stylesheet update.

Introduce Document::updateActiveStyle() and corresponding
updateActiveStyle()/updateActiveStyleSheets() methods in StyleEngine to
prepare for doing active stylesheet updates as part of
updateStyleAndLayoutTree.

We move updateViewport() to updateActiveStyle() as the first step. This
is done by removing the synchronous calls to ViewportStyleResolver::
updateViewport() and instead schedule a layout tree update. In order to
trigger actual work to be done when the layout tree update happens, we
need to return true from Document::needsFullLayoutTreeUpdate() when we
need an active style update (for viewport atm).

BUG=567021
==========

to

==========
Make updateStyleAndLayoutTree ready for async stylesheet update.

Introduce Document::updateActiveStyle() and corresponding
updateActiveStyle()/updateActiveStyleSheets() methods in StyleEngine to
prepare for doing active stylesheet updates as part of
updateStyleAndLayoutTree.

We move updateViewport() to updateActiveStyle() as the first step. This
is done by removing the synchronous calls to ViewportStyleResolver::
updateViewport() and instead schedule a layout tree update. In order to
trigger actual work to be done when the layout tree update happens, we
need to return true from Document::needsFullLayoutTreeUpdate() when we
need an active style update (for viewport atm).

BUG=567021

Committed: https://crrev.com/b50a2f4a9fe9733ed204f55f83a2e32727ba003d
Cr-Commit-Position: refs/heads/master@{#432182}
==========

[commit-bot: I haz the power, 2016-11-15 15:28:33]

Patchset 3 (id:??) landed as
https://crrev.com/b50a2f4a9fe9733ed204f55f83a2e32727ba003d
Cr-Commit-Position: refs/heads/master@{#432182}