Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2484833003: DevTools: teach automapping to deal with network resources with file:// urls (Closed)

Created:
4 years, 1 month ago by lushnikov
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: teach automapping to deal with network resources with file:// urls This patch teaches Automapping to properly deal with file:// urls. As the file:// url is unique, the automapping simply should check if there's a file for such a url. This comes handy when automapping node.js scripts, since node.js reports its scripts with absolute file path. BUG=none R=dgozman Committed: https://crrev.com/b7329b95c15aae9823d1fc9f27605df647bb05c2 Cr-Commit-Position: refs/heads/master@{#430715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-absolute-paths.html View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/persistence/automapping-absolute-paths-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/persistence/Automapping.js View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
lushnikov
please, take a look
4 years, 1 month ago (2016-11-08 06:50:56 UTC) #1
dgozman
lgtm
4 years, 1 month ago (2016-11-08 20:48:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484833003/1
4 years, 1 month ago (2016-11-08 21:19:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 21:27:04 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 21:29:28 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7329b95c15aae9823d1fc9f27605df647bb05c2
Cr-Commit-Position: refs/heads/master@{#430715}

Powered by Google App Engine
This is Rietveld 408576698