Issue 2484823002: Stop double counting link rel preload preloads for metrics tracking

Issue 2484823002: Stop double counting link rel preload preloads for metrics tracking (Closed)

Created:
4 years, 1 month ago by Charlie Harrison

Modified:
4 years, 1 month ago

Reviewers:
Yoav Weiss

CC:
chromium-reviews, tyoshino+watch_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Stop double counting link rel preload preloads for metrics tracking BUG=662999 Committed: https://crrev.com/b16ccbe3a354e81615ebf805b503a0fae5362492 Cr-Commit-Position: refs/heads/master@{#431909}

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	third_party/WebKit/Source/core/fetch/ResourceFetcher.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp	View		4 chunks	+7 lines, -5 lines	0 comments	Download

Total messages: 14 (7 generated)

Charlie Harrison

Yoav, WDYT? All of my (half baked) hypotheses for the @import scanner problem has to ...

4 years, 1 month ago (2016-11-07 18:36:25 UTC) #4

Yoav Weiss

On 2016/11/14 17:38:38, Charlie Harrison wrote: > Yoav, friendly ping Sorry for the delay (travel...) ...

4 years, 1 month ago (2016-11-14 17:55:41 UTC) #8

Charlie Harrison

No worries, just wanted to get this in before the change to make CSSPreloadScanner hold ...

4 years, 1 month ago (2016-11-14 17:57:49 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484823002/1

4 years, 1 month ago (2016-11-14 17:58:38 UTC) #11

commit-bot: I haz the power

4 years, 1 month ago (2016-11-14 20:10:22 UTC) #14

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b16ccbe3a354e81615ebf805b503a0fae5362492
Cr-Commit-Position: refs/heads/master@{#431909}