Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/BUILD.gn

Issue 2484803003: Move WTF::SpinLock to base::SpinLock. (Closed)
Patch Set: base::SpinLock → base::subtle::SpinLock, plus a warning comment. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/synchronization/spin_lock.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index 141dc2b7552a4bbbafa9824c1af0823ddd8a7910..cb6e3e9cf54d223f0a0387a5f108e0d62928b436 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -1207,6 +1207,14 @@ component("base") {
"rand_util_nacl.cc",
"synchronization/read_write_lock_nacl.cc",
]
+
+ # Add stuff that doesn't work in NaCl.
+ sources += [
+ # SpinLock uses GNU-style inline assembly, which the pnacl-clang++
+ # compiler doesn't allow.
+ "synchronization/spin_lock.cc",
+ "synchronization/spin_lock.h",
+ ]
}
# Windows.
« no previous file with comments | « no previous file | base/synchronization/spin_lock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698