Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: base/BUILD.gn

Issue 2484803003: Move WTF::SpinLock to base::SpinLock. (Closed)
Patch Set: base::SpinLock → base::subtle::SpinLock, plus a warning comment. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/synchronization/spin_lock.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # HOW TO WRITE CONDITIONALS IN THIS FILE 5 # HOW TO WRITE CONDITIONALS IN THIS FILE
6 # ====================================== 6 # ======================================
7 # 7 #
8 # In many other places, one would write a conditional that expresses all the 8 # In many other places, one would write a conditional that expresses all the
9 # cases when a source file is used or unused, and then either add or subtract 9 # cases when a source file is used or unused, and then either add or subtract
10 # it from the sources list in that case 10 # it from the sources list in that case
(...skipping 1189 matching lines...) Expand 10 before | Expand all | Expand 10 after
1200 } 1200 }
1201 } else { 1201 } else {
1202 # Remove NaCl stuff. 1202 # Remove NaCl stuff.
1203 sources -= [ 1203 sources -= [
1204 "memory/shared_memory_nacl.cc", 1204 "memory/shared_memory_nacl.cc",
1205 "os_compat_nacl.cc", 1205 "os_compat_nacl.cc",
1206 "os_compat_nacl.h", 1206 "os_compat_nacl.h",
1207 "rand_util_nacl.cc", 1207 "rand_util_nacl.cc",
1208 "synchronization/read_write_lock_nacl.cc", 1208 "synchronization/read_write_lock_nacl.cc",
1209 ] 1209 ]
1210
1211 # Add stuff that doesn't work in NaCl.
1212 sources += [
1213 # SpinLock uses GNU-style inline assembly, which the pnacl-clang++
1214 # compiler doesn't allow.
1215 "synchronization/spin_lock.cc",
1216 "synchronization/spin_lock.h",
1217 ]
1210 } 1218 }
1211 1219
1212 # Windows. 1220 # Windows.
1213 if (is_win) { 1221 if (is_win) {
1214 sources += [ 1222 sources += [
1215 "power_monitor/power_monitor_device_source_win.cc", 1223 "power_monitor/power_monitor_device_source_win.cc",
1216 "profiler/win32_stack_frame_unwinder.cc", 1224 "profiler/win32_stack_frame_unwinder.cc",
1217 "profiler/win32_stack_frame_unwinder.h", 1225 "profiler/win32_stack_frame_unwinder.h",
1218 ] 1226 ]
1219 1227
(...skipping 1270 matching lines...) Expand 10 before | Expand all | Expand 10 after
2490 } 2498 }
2491 2499
2492 fuzzer_test("base_json_correctness_fuzzer") { 2500 fuzzer_test("base_json_correctness_fuzzer") {
2493 sources = [ 2501 sources = [
2494 "json/correctness_fuzzer.cc", 2502 "json/correctness_fuzzer.cc",
2495 ] 2503 ]
2496 deps = [ 2504 deps = [
2497 ":base", 2505 ":base",
2498 ] 2506 ]
2499 } 2507 }
OLDNEW
« no previous file with comments | « no previous file | base/synchronization/spin_lock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698