Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2484803002: [wasm] Mutable globals cannot be imported (Closed)

Created:
4 years, 1 month ago by ahaas
Modified:
4 years, 1 month ago
Reviewers:
titzer, rossberg
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Mutable globals cannot be imported This fixes another spec tests. R=rossberg@chromium.org, titzer@chromium.org TEST=WasmModuleVerifyTest.ImportTable_mutable_global Committed: https://crrev.com/e4bae133098ae6b4785219f2f6e0becf00d27d64 Cr-Commit-Position: refs/heads/master@{#40831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M src/wasm/module-decoder.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ahaas
4 years, 1 month ago (2016-11-07 17:27:38 UTC) #1
titzer
lgtm
4 years, 1 month ago (2016-11-07 17:33:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484803002/1
4 years, 1 month ago (2016-11-08 13:23:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 13:25:06 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:26:01 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4bae133098ae6b4785219f2f6e0becf00d27d64
Cr-Commit-Position: refs/heads/master@{#40831}

Powered by Google App Engine
This is Rietveld 408576698