Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2484793002: Remove access to WebContents in RWHVA::SynchronousFrameMetadata() (Closed)
Patch Set: case-by-case Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 78c0d2271379a3629f84f3621665b921121d1daf..6ad47b4812cf836efd58bbe856b1be46a5aae88b 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -600,12 +600,6 @@ void RenderWidgetHostViewAndroid::Focus() {
host_->Focus();
if (overscroll_controller_)
overscroll_controller_->Enable();
- if (content_view_core_) {
- WebContentsImpl* web_contents_impl =
- static_cast<WebContentsImpl*>(content_view_core_->GetWebContents());
- if (web_contents_impl->ShowingInterstitialPage())
- content_view_core_->ForceUpdateImeAdapter(GetNativeImeAdapter());
- }
}
bool RenderWidgetHostViewAndroid::HasFocus() const {
@@ -1191,10 +1185,12 @@ void RenderWidgetHostViewAndroid::SynchronousFrameMetadata(
OnFrameMetadataUpdated(frame_metadata.Clone(), false);
// DevTools ScreenCast support for Android WebView.
- WebContents* web_contents = content_view_core_->GetWebContents();
- if (DevToolsAgentHost::HasFor(web_contents)) {
+ RenderFrameHost* frame_host = RenderViewHost::From(host_)->GetMainFrame();
+ if (!frame_host)
boliu 2016/11/08 00:13:55 can merge this with the HasFor check
Jinsuk Kim 2016/11/08 17:58:19 Done.
+ return;
+ if (DevToolsAgentHost::HasFor(frame_host)) {
scoped_refptr<DevToolsAgentHost> dtah =
- DevToolsAgentHost::GetOrCreateFor(web_contents);
+ DevToolsAgentHost::GetOrCreateFor(frame_host);
// Unblock the compositor.
BrowserThread::PostTask(
BrowserThread::UI, FROM_HERE,
@@ -1790,8 +1786,7 @@ void RenderWidgetHostViewAndroid::SetContentViewCore(
}
if (!sync_compositor_) {
- sync_compositor_ = SynchronousCompositorHost::Create(
- this, content_view_core_->GetWebContents());
+ sync_compositor_ = SynchronousCompositorHost::Create(this);
}
}

Powered by Google App Engine
This is Rietveld 408576698