Remove access to WebContents in RWHVA::SynchronousFrameMetadata()

content/public/browser/devtools_agent_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_DEVTOOLS_AGENT_HOST_H_
 #define CONTENT_PUBLIC_BROWSER_DEVTOOLS_AGENT_HOST_H_
 
 #include <memory>
 #include <string>
 #include <vector>
@@ skipping 46 matching lines @@
 
   // Returns DevToolsAgentHost that can be used for inspecting |web_contents|.
   // A new DevToolsAgentHost will be created if it does not exist.
   static scoped_refptr<DevToolsAgentHost> GetOrCreateFor(
       WebContents* web_contents);
 
   // Returns DevToolsAgentHost that can be used for inspecting |frame_host|.
   // A new DevToolsAgentHost will be created if it does not exist.
   // For main frame cases, prefer using the above method which takes WebContents
   // instead.
   // TODO(dgozman): this is a temporary measure until we can inspect

[boliu, 2016/11/08 00:13:55]

says here accessor for RFH is temporary, perhaps we don't want to add more to
this dependency..

[Jinsuk Kim, 2016/11/08 17:58:19]

Granted, I just dgozman would take care of my addition too when he comes back to
clear them up all.

   // cross-process subframes within a single agent.
   static scoped_refptr<DevToolsAgentHost> GetOrCreateFor(
       RenderFrameHost* frame_host);
 
   // Returns true iff an instance of DevToolsAgentHost for the |web_contents|
   // does exist.
   static bool HasFor(WebContents* web_contents);
+  static bool HasFor(RenderFrameHost* frame_host);

[boliu, 2016/11/08 00:13:55]

parameter overloading is not allowed by style guide, need to rename this
something else..

plus this doesn't need to be on the public interface

[Jinsuk Kim, 2016/11/08 17:58:19]

Moved to RenderFrameDevToolsAgentHost.

 
   // Returns DevToolsAgentHost that can be used for inspecting shared worker
   // with given worker process host id and routing id.
   static scoped_refptr<DevToolsAgentHost> GetForWorker(int worker_process_id,
                                                        int worker_route_id);
 
   // Creates DevToolsAgentHost that communicates to the target by means of
   // provided |delegate|. |delegate| ownership is passed to the created agent
   // host.
   static scoped_refptr<DevToolsAgentHost> Forward(
@@ skipping 121 matching lines @@
   static void DetachAllClients();
 
  protected:
   friend class base::RefCounted<DevToolsAgentHost>;
   virtual ~DevToolsAgentHost() {}
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_DEVTOOLS_AGENT_HOST_H_