Store ref in field trial in child processes

Store ref in field trial in child processes

This CL stores the ref in the field trial in child processes, so we can
look them up later when we will have experiment parameters associated
with them in shared memory. Also initializes the allocator in the child
process when we're creating the field trials so we have a handle on that as well.

BUG=662942
Committed: https://crrev.com/8c13daefb5958061dce05d10bbe22992635a8645
Cr-Commit-Position: refs/heads/master@{#430718}

[lawrencewu, 2016-11-07 16:50:24]

lawrencewu@chromium.org changed reviewers:
+ asvitkine@chromium.org

[lawrencewu, 2016-11-07 16:50:25]

initial CL

[lawrencewu, 2016-11-07 17:27:43]

Description was changed from

==========
Store ref in field trial in child processes

This CL stores the ref in the field trial in child processes, so we can
look them up later when we will have experiment parameters associated
with them in shared memory.

BUG=662942
==========

to

==========
Store ref in field trial in child processes

This CL stores the ref in the field trial in child processes, so we can
look them up later when we will have experiment parameters associated
with them in shared memory. Also initializes the allocator in the child process
when we're creating the field trials so we have a handle on that as well.

BUG=662942
==========

[Alexei Svitkine (slow), 2016-11-07 18:31:33]

Please wrap the last sentence of the paragraph in your CL description.

https://codereview.chromium.org/2484773002/diff/1/base/metrics/field_trial.cc
File base/metrics/field_trial.cc (right):

https://codereview.chromium.org/2484773002/diff/1/base/metrics/field_trial.cc...
base/metrics/field_trial.cc:944: if (allocator && allocator->IsReadonly())
This is needed because now the child process actually sets
field_trial_allocator_? Please add a comment.

Also, expand the comment on the field_trial_allocator_ field in the header file.

[lawrencewu, 2016-11-07 18:47:53]

Description was changed from

==========
Store ref in field trial in child processes

This CL stores the ref in the field trial in child processes, so we can
look them up later when we will have experiment parameters associated
with them in shared memory. Also initializes the allocator in the child process
when we're creating the field trials so we have a handle on that as well.

BUG=662942
==========

to

==========
Store ref in field trial in child processes

This CL stores the ref in the field trial in child processes, so we can
look them up later when we will have experiment parameters associated
with them in shared memory. Also initializes the allocator in the child
process when we're creating the field trials so we have a handle on that as
well.

BUG=662942
==========

[lawrencewu, 2016-11-07 18:55:45]

The CQ bit was checked by lawrencewu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 18:56:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lawrencewu, 2016-11-07 19:11:37]

Added comments.

https://codereview.chromium.org/2484773002/diff/1/base/metrics/field_trial.cc
File base/metrics/field_trial.cc (right):

https://codereview.chromium.org/2484773002/diff/1/base/metrics/field_trial.cc...
base/metrics/field_trial.cc:944: if (allocator && allocator->IsReadonly())
On 2016/11/07 18:31:33, Alexei Svitkine (very slow) wrote:
> This is needed because now the child process actually sets
> field_trial_allocator_? Please add a comment.
> 
> Also, expand the comment on the field_trial_allocator_ field in the header
file.

Yes, that's correct. Added comments to both places.

[commit-bot: I haz the power, 2016-11-07 19:55:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 19:55:26]

Dry run: This issue passed the CQ dry run.

[Alexei Svitkine (slow), 2016-11-08 18:49:56]

lgtm

[lawrencewu, 2016-11-08 19:19:53]

The CQ bit was checked by lawrencewu@chromium.org

[commit-bot: I haz the power, 2016-11-08 19:20:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 21:30:27]

Description was changed from

==========
Store ref in field trial in child processes

This CL stores the ref in the field trial in child processes, so we can
look them up later when we will have experiment parameters associated
with them in shared memory. Also initializes the allocator in the child
process when we're creating the field trials so we have a handle on that as
well.

BUG=662942
==========

to

==========
Store ref in field trial in child processes

This CL stores the ref in the field trial in child processes, so we can
look them up later when we will have experiment parameters associated
with them in shared memory. Also initializes the allocator in the child
process when we're creating the field trials so we have a handle on that as
well.

BUG=662942
==========

[commit-bot: I haz the power, 2016-11-08 21:30:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-08 21:38:40]

Description was changed from

==========
Store ref in field trial in child processes

This CL stores the ref in the field trial in child processes, so we can
look them up later when we will have experiment parameters associated
with them in shared memory. Also initializes the allocator in the child
process when we're creating the field trials so we have a handle on that as
well.

BUG=662942
==========

to

==========
Store ref in field trial in child processes

This CL stores the ref in the field trial in child processes, so we can
look them up later when we will have experiment parameters associated
with them in shared memory. Also initializes the allocator in the child
process when we're creating the field trials so we have a handle on that as
well.

BUG=662942

Committed: https://crrev.com/8c13daefb5958061dce05d10bbe22992635a8645
Cr-Commit-Position: refs/heads/master@{#430718}
==========

[commit-bot: I haz the power, 2016-11-08 21:38:40]

Patchset 2 (id:??) landed as
https://crrev.com/8c13daefb5958061dce05d10bbe22992635a8645
Cr-Commit-Position: refs/heads/master@{#430718}