Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2484763005: media: Support transporting 0-byte DecoderBuffer over mojo (Closed)

Created:
4 years, 1 month ago by xhwang
Modified:
4 years, 1 month ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, alokp+watch_chromium.org, darin (slow to review), wolenetz
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Support transporting 0-byte DecoderBuffer over mojo BUG=663438 TEST=Added a new unitttest. Committed: https://crrev.com/98da7afb903cd39d1c695b33c5fa23e59d9da0e8 Cr-Commit-Position: refs/heads/master@{#430883}

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M media/mojo/common/media_type_converters.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M media/mojo/common/mojo_decoder_buffer_converter.cc View 2 chunks +4 lines, -2 lines 2 comments Download
M media/mojo/common/mojo_decoder_buffer_converter_unittest.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M media/mojo/interfaces/media_types.mojom View 1 chunk +6 lines, -1 line 4 comments Download

Messages

Total messages: 22 (7 generated)
xhwang
PTAL
4 years, 1 month ago (2016-11-08 20:03:11 UTC) #2
alokp
non-owner lgtm https://codereview.chromium.org/2484763005/diff/1/media/mojo/interfaces/media_types.mojom File media/mojo/interfaces/media_types.mojom (right): https://codereview.chromium.org/2484763005/diff/1/media/mojo/interfaces/media_types.mojom#newcode108 media/mojo/interfaces/media_types.mojom:108: bool is_end_of_stream; If "data_size == 0 && ...
4 years, 1 month ago (2016-11-08 21:34:08 UTC) #3
wolenetz
Over to chcunningham@ - I'm heads down on ffmpeg roll currently.
4 years, 1 month ago (2016-11-08 21:34:12 UTC) #5
chcunningham
lgtm https://codereview.chromium.org/2484763005/diff/1/media/mojo/common/mojo_decoder_buffer_converter.cc File media/mojo/common/mojo_decoder_buffer_converter.cc (right): https://codereview.chromium.org/2484763005/diff/1/media/mojo/common/mojo_decoder_buffer_converter.cc#newcode107 media/mojo/common/mojo_decoder_buffer_converter.cc:107: if (media_buffer->end_of_stream() || media_buffer->data_size() == 0) { Could ...
4 years, 1 month ago (2016-11-08 22:00:38 UTC) #6
xhwang
https://codereview.chromium.org/2484763005/diff/1/media/mojo/common/mojo_decoder_buffer_converter.cc File media/mojo/common/mojo_decoder_buffer_converter.cc (right): https://codereview.chromium.org/2484763005/diff/1/media/mojo/common/mojo_decoder_buffer_converter.cc#newcode107 media/mojo/common/mojo_decoder_buffer_converter.cc:107: if (media_buffer->end_of_stream() || media_buffer->data_size() == 0) { On 2016/11/08 ...
4 years, 1 month ago (2016-11-08 22:13:51 UTC) #7
xhwang
dcheng: mojom OWNERS review please!
4 years, 1 month ago (2016-11-08 22:14:16 UTC) #9
alokp
https://codereview.chromium.org/2484763005/diff/1/media/mojo/interfaces/media_types.mojom File media/mojo/interfaces/media_types.mojom (right): https://codereview.chromium.org/2484763005/diff/1/media/mojo/interfaces/media_types.mojom#newcode108 media/mojo/interfaces/media_types.mojom:108: bool is_end_of_stream; On 2016/11/08 22:13:51, xhwang wrote: > On ...
4 years, 1 month ago (2016-11-08 22:17:30 UTC) #10
xhwang
https://codereview.chromium.org/2484763005/diff/1/media/mojo/interfaces/media_types.mojom File media/mojo/interfaces/media_types.mojom (right): https://codereview.chromium.org/2484763005/diff/1/media/mojo/interfaces/media_types.mojom#newcode108 media/mojo/interfaces/media_types.mojom:108: bool is_end_of_stream; On 2016/11/08 22:17:30, alokp wrote: > On ...
4 years, 1 month ago (2016-11-08 22:28:35 UTC) #11
dcheng
mojo lgtm, but this seems pretty complex to reason about =/
4 years, 1 month ago (2016-11-08 22:31:00 UTC) #12
xhwang
On 2016/11/08 22:31:00, dcheng wrote: > mojo lgtm, but this seems pretty complex to reason ...
4 years, 1 month ago (2016-11-08 22:32:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484763005/1
4 years, 1 month ago (2016-11-08 22:33:24 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/328053)
4 years, 1 month ago (2016-11-09 02:21:37 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484763005/1
4 years, 1 month ago (2016-11-09 05:51:51 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 07:18:45 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 07:20:30 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98da7afb903cd39d1c695b33c5fa23e59d9da0e8
Cr-Commit-Position: refs/heads/master@{#430883}

Powered by Google App Engine
This is Rietveld 408576698