Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: cc/trees/layer_tree_host_in_process.cc

Issue 2484743002: UMA metric for LayerUpdateTimes (Closed)
Patch Set: address feedback Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/layer_tree_host_in_process.cc
diff --git a/cc/trees/layer_tree_host_in_process.cc b/cc/trees/layer_tree_host_in_process.cc
index 8a9d969f3a6e84dd2ccfa29311a4a836ea8cfa63..f0d93900313c8aee46dfe7df39ba5e1d16441ca7 100644
--- a/cc/trees/layer_tree_host_in_process.cc
+++ b/cc/trees/layer_tree_host_in_process.cc
@@ -23,9 +23,12 @@
#include "base/single_thread_task_runner.h"
#include "base/stl_util.h"
#include "base/strings/string_number_conversions.h"
+#include "base/strings/stringprintf.h"
#include "base/threading/thread_task_runner_handle.h"
+#include "base/timer/elapsed_timer.h"
#include "base/trace_event/trace_event.h"
#include "base/trace_event/trace_event_argument.h"
+#include "cc/base/histograms.h"
#include "cc/base/math_util.h"
#include "cc/blimp/client_picture_cache.h"
#include "cc/blimp/engine_picture_cache.h"
@@ -582,12 +585,38 @@ void LayerTreeHostInProcess::Composite(base::TimeTicks frame_begin_time) {
proxy->CompositeImmediately(frame_begin_time);
}
+static int GetLayersUpdateTimeHistogramBucket(size_t numLayers) {
+ // We uses the following exponential (ratio 2) bucketization:
+ // [0, 10), [10, 30), [30, 70), [70, 150), [150, infinity)
+ if (numLayers < 10)
+ return 0;
+ if (numLayers < 30)
+ return 1;
+ if (numLayers < 70)
+ return 2;
+ if (numLayers < 150)
+ return 3;
+ return 4;
+}
+
bool LayerTreeHostInProcess::UpdateLayers() {
if (!layer_tree_->root_layer())
return false;
DCHECK(!layer_tree_->root_layer()->parent());
+ base::ElapsedTimer timer;
+
bool result = DoUpdateLayers(layer_tree_->root_layer());
micro_benchmark_controller_.DidUpdateLayers();
+
+ if (const char* client_name = GetClientNameForMetrics()) {
+ std::string histogram_name = base::StringPrintf(
+ "Compositing.%s.LayersUpdateTime.%d", client_name,
+ GetLayersUpdateTimeHistogramBucket(layer_tree_->NumLayers()));
+ base::Histogram::FactoryGet(histogram_name, 0, 10000000, 50,
+ base::HistogramBase::kUmaTargetedHistogramFlag)
+ ->Add(timer.Elapsed().InMicroseconds());
+ }
+
return result || next_commit_forces_redraw_;
}

Powered by Google App Engine
This is Rietveld 408576698