Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issue 2484723002: [crankshaft] Do not optimize argument access if any parameter is context-allocated. (Closed)

Created:
4 years, 1 month ago by Jarin
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Do not optimize argument access if any parameter is context-allocated. Note: This CL might regress code that relies on such arguments access. In that case, we could still optimize the access if it accesses at constant index (and the argument at that index is not context-allocated). If any code relies on a general access to context-allocated arguments, we would need to analyze the function for assignment to the arguments - this might be quite tricky. BUG=chromium:662845 Committed: https://crrev.com/7f801ff35bfd8eac6fc0e64a1b12471ba90f7ad8 Cr-Commit-Position: refs/heads/master@{#40813}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -21 lines) Patch
M src/crankshaft/hydrogen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 3 chunks +11 lines, -15 lines 0 comments Download
A + test/mjsunit/regress/regress-662845.js View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Jarin
Could you take a look, please?
4 years, 1 month ago (2016-11-07 15:55:22 UTC) #6
Benedikt Meurer
lgtm
4 years, 1 month ago (2016-11-07 18:34:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484723002/1
4 years, 1 month ago (2016-11-07 19:06:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 19:09:30 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:25:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f801ff35bfd8eac6fc0e64a1b12471ba90f7ad8
Cr-Commit-Position: refs/heads/master@{#40813}

Powered by Google App Engine
This is Rietveld 408576698