Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2484713002:
[debugger] Add entire directory to files in .isolate (Closed)
Description[debugger] Add entire directory to files in .isolate
Previously, tests in the newly added test/debugger/debug directory were
not executed on CQ.
BUG=v8:5530
Committed: https://crrev.com/5a44be9a25c13f85e5b0c6ef759dfc6871bb0957
Cr-Commit-Position: refs/heads/master@{#40819}
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)
The CQ bit was checked by jgruber@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
jgruber@chromium.org changed reviewers: + yangguo@chromium.org
machenbach@chromium.org changed reviewers: + machenbach@chromium.org
lgtm, did you check in the output that the tests are now executed?
On 2016/11/08 08:17:26, machenbach (slow) wrote: > lgtm, did you check in the output that the tests are now executed? Looks good: Done running debugger/debug/debug-compile-optimized: pass https://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/...
The CQ bit was checked by jgruber@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
On 2016/11/08 08:48:22, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) lgtm.
Message was sent while issue was closed.
Description was changed from ========== [debugger] Add entire directory to files in .isolate Previously, tests in the newly added test/debugger/debug directory were not executed on CQ. BUG=v8:5530 ========== to ========== [debugger] Add entire directory to files in .isolate Previously, tests in the newly added test/debugger/debug directory were not executed on CQ. BUG=v8:5530 Committed: https://crrev.com/5a44be9a25c13f85e5b0c6ef759dfc6871bb0957 Cr-Commit-Position: refs/heads/master@{#40819} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5a44be9a25c13f85e5b0c6ef759dfc6871bb0957 Cr-Commit-Position: refs/heads/master@{#40819} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
