Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2484643003: Revert of Restore maximized window position after detaching display. (Closed)

Created:
4 years, 1 month ago by sky
Modified:
4 years, 1 month ago
Reviewers:
atimoxin, ananta
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Restore maximized window position after detaching display. (patchset #2 id:20001 of https://codereview.chromium.org/2379063003/ ) Reason for revert: This resulted in a shortcut to move between monitors not working. See 656001. Original issue's description: > Restore maximized window position after detaching display. > > Sometimes Windows incorrectly changes bounds of maximized windows after > attaching or detaching additional displays. In this case user can see > non-client area of the window (that should be hidden in normal case). > > This workaround code restores window position if problem occurs. > > BUG=651449 > > Committed: https://crrev.com/6bb7f81927671c8616a89ad235d797159724cf09 > Cr-Commit-Position: refs/heads/master@{#424123} TBR=ananta@chromium.org,atimoxin@yandex-team.ru # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=651449 Committed: https://crrev.com/f4e3503b4006f36939543c91a45c1c9feb9f1433 Cr-Commit-Position: refs/heads/master@{#430336}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -27 lines) Patch
M ui/views/win/hwnd_message_handler.cc View 3 chunks +6 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sky
Created Revert of Restore maximized window position after detaching display.
4 years, 1 month ago (2016-11-07 18:20:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484643003/1
4 years, 1 month ago (2016-11-07 18:20:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 19:06:44 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 19:15:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4e3503b4006f36939543c91a45c1c9feb9f1433
Cr-Commit-Position: refs/heads/master@{#430336}

Powered by Google App Engine
This is Rietveld 408576698