[wasm] Compare the maximum memory size with the spec limit, not with the V8 limit

[wasm] Compare the maximum memory size with the spec limit, not with the V8 limit

The maximum memory size is a user-defined upper limit for the size of
the memory of a WebAssembly instance. The actual limit is the minimum of
the user-defined limit and the V8 limit. With this CL we allow the
user-defined limit to be greater than the V8 limit, which is required by
the spec.

R=titzer@chromium.org
CC=gdeepti@chromium.org

TEST=unittests/WasmModuleVerifyTest.MaxMaximumMemorySize

Committed: https://crrev.com/15d4984b9cf5a22a7c7732ca51d2a13a573c4784
Cr-Commit-Position: refs/heads/master@{#40801}

[ahaas, 2016-11-07 11:00:37]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 11:00:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 11:26:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 11:26:23]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-11-07 11:41:58]

lgtm with comment

https://codereview.chromium.org/2484643002/diff/1/test/unittests/wasm/module-...
File test/unittests/wasm/module-decoder-unittest.cc (right):

https://codereview.chromium.org/2484643002/diff/1/test/unittests/wasm/module-...
test/unittests/wasm/module-decoder-unittest.cc:478: TEST_F(WasmModuleVerifyTest,
MaxMaximumMemorySize) {
Can you also add a negative test?

[ahaas, 2016-11-07 11:51:34]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 11:51:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-11-07 11:52:17]

https://codereview.chromium.org/2484643002/diff/1/test/unittests/wasm/module-...
File test/unittests/wasm/module-decoder-unittest.cc (right):

https://codereview.chromium.org/2484643002/diff/1/test/unittests/wasm/module-...
test/unittests/wasm/module-decoder-unittest.cc:478: TEST_F(WasmModuleVerifyTest,
MaxMaximumMemorySize) {
On 2016/11/07 at 11:41:57, titzer wrote:
> Can you also add a negative test?

Done.

[commit-bot: I haz the power, 2016-11-07 12:16:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 12:16:59]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-11-07 12:23:57]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-11-07 12:23:58]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2484643002/#ps20001
(title: "Add a negative test")

[commit-bot: I haz the power, 2016-11-07 12:24:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 12:25:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:24:34]

Description was changed from

==========
[wasm] Compare the maximum memory size with the spec limit, not with the V8
limit

The maximum memory size is a user-defined upper limit for the size of
the memory of a WebAssembly instance. The actual limit is the minimum of
the user-defined limit and the V8 limit. With this CL we allow the
user-defined limit to be greater than the V8 limit, which is required by
the spec.

R=titzer@chromium.org
CC=gdeepti@chromium.org

TEST=unittests/WasmModuleVerifyTest.MaxMaximumMemorySize
==========

to

==========
[wasm] Compare the maximum memory size with the spec limit, not with the V8
limit

The maximum memory size is a user-defined upper limit for the size of
the memory of a WebAssembly instance. The actual limit is the minimum of
the user-defined limit and the V8 limit. With this CL we allow the
user-defined limit to be greater than the V8 limit, which is required by
the spec.

R=titzer@chromium.org
CC=gdeepti@chromium.org

TEST=unittests/WasmModuleVerifyTest.MaxMaximumMemorySize

Committed: https://crrev.com/15d4984b9cf5a22a7c7732ca51d2a13a573c4784
Cr-Commit-Position: refs/heads/master@{#40801}
==========

[commit-bot: I haz the power, 2016-11-17 22:24:35]

Patchset 2 (id:??) landed as
https://crrev.com/15d4984b9cf5a22a7c7732ca51d2a13a573c4784
Cr-Commit-Position: refs/heads/master@{#40801}