third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp - Issue 2484633004: Change Lo-Fi bool to bitmask to support multiple Previews types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp

Issue 2484633004: Change Lo-Fi bool to bitmask to support multiple Previews types (Closed)

Patch Set: fix ContentResourceProviderTest Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/resource/ImageResource.cpp ('k') | third_party/WebKit/Source/platform/exported/WebURLRequest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp

diff --git a/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp b/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp

index 372dd6a46ba7f271b6cb15708cb07074ebb8d07d..e65dbb44b030d262ea698359f8e6230be99ad496 100644

--- a/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp

+++ b/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp

@@ -402,7 +402,7 @@ TEST(ImageResourceTest, ReloadIfLoFiOrPlaceholderAfterFinished) {

KURL testURL(ParsedURLString, "http://www.test.com/cancelTest.html");

ScopedRegisteredURL scopedRegisteredURL(testURL);

ResourceRequest request = ResourceRequest(testURL);

- request.setLoFiState(WebURLRequest::LoFiOn);

+ request.setPreviewsState(WebURLRequest::ServerLoFiOn);

ImageResource* imageResource = ImageResource::create(request);

imageResource->setStatus(Resource::Pending);

@@ -470,7 +470,7 @@ TEST(ImageResourceTest, ReloadIfLoFiOrPlaceholderDuringFetch) {

ScopedRegisteredURL scopedRegisteredURL(testURL);

ResourceRequest request(testURL);

- request.setLoFiState(WebURLRequest::LoFiOn);

+ request.setPreviewsState(WebURLRequest::ServerLoFiOn);

FetchRequest fetchRequest(request, FetchInitiatorInfo());

ResourceFetcher* fetcher =

ResourceFetcher::create(ImageResourceTestMockFetchContext::create());