Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1266)

Unified Diff: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

Issue 2484633004: Change Lo-Fi bool to bitmask to support multiple Previews types (Closed)
Patch Set: fix ContentResourceProviderTest Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
diff --git a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
index f4e44fbb53675fcfc480660eb3831b56f50e5709..a628def301ebdf5b14daa12894973aeeffb3ffe6 100644
--- a/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
+++ b/extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
@@ -16,6 +16,7 @@
#include "base/run_loop.h"
#include "base/values.h"
#include "content/public/browser/resource_request_info.h"
+#include "content/public/common/previews_state.h"
#include "extensions/browser/api/declarative_webrequest/webrequest_condition.h"
#include "extensions/browser/api/declarative_webrequest/webrequest_constants.h"
#include "net/base/request_priority.h"
@@ -106,31 +107,31 @@ TEST(WebRequestConditionAttributeTest, ResourceType) {
GURL("http://www.example.com"), net::DEFAULT_PRIORITY, NULL));
content::ResourceRequestInfo::AllocateForTesting(
url_request_ok.get(), content::RESOURCE_TYPE_SUB_FRAME,
- NULL, // context
- -1, // render_process_id
- -1, // render_view_id
- -1, // render_frame_id
- false, // is_main_frame
- false, // parent_is_main_frame
- true, // allow_download
- false, // is_async
- false); // is_using_lofi
- EXPECT_TRUE(attribute->IsFulfilled(WebRequestData(url_request_ok.get(),
- ON_BEFORE_REQUEST)));
+ NULL, // context
+ -1, // render_process_id
+ -1, // render_view_id
+ -1, // render_frame_id
+ false, // is_main_frame
+ false, // parent_is_main_frame
+ true, // allow_download
+ false, // is_async
+ content::PREVIEWS_OFF);
+ EXPECT_TRUE(attribute->IsFulfilled(
+ WebRequestData(url_request_ok.get(), ON_BEFORE_REQUEST)));
std::unique_ptr<net::URLRequest> url_request_fail(context.CreateRequest(
GURL("http://www.example.com"), net::DEFAULT_PRIORITY, NULL));
content::ResourceRequestInfo::AllocateForTesting(
url_request_fail.get(), content::RESOURCE_TYPE_MAIN_FRAME,
- NULL, // context
- -1, // render_process_id
- -1, // render_view_id
- -1, // render_frame_id
- true, // is_main_frame
- false, // parent_is_main_frame
- true, // allow_download
- false, // is_async
- false); // is_using_lofi
+ NULL, // context
+ -1, // render_process_id
+ -1, // render_view_id
+ -1, // render_frame_id
+ true, // is_main_frame
+ false, // parent_is_main_frame
+ true, // allow_download
+ false, // is_async
+ content::PREVIEWS_OFF);
EXPECT_FALSE(attribute->IsFulfilled(WebRequestData(url_request_fail.get(),
ON_BEFORE_REQUEST)));
}

Powered by Google App Engine
This is Rietveld 408576698