Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1213)

Unified Diff: chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc

Issue 2484633004: Change Lo-Fi bool to bitmask to support multiple Previews types (Closed)
Patch Set: thakis comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc
diff --git a/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc b/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc
index 4221ac0750fb099daf4cb65b736155b25584b447..569b3a4d506b8a0332f7888b399a3808afd72157 100644
--- a/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc
+++ b/chrome/browser/data_use_measurement/chrome_data_use_ascriber_unittest.cc
@@ -12,6 +12,7 @@
#include "components/data_use_measurement/core/data_use_recorder.h"
#include "content/public/browser/resource_request_info.h"
#include "content/public/common/browser_side_navigation_policy.h"
+#include "content/public/common/previews_state.h"
#include "content/public/common/process_type.h"
#include "content/public/test/mock_resource_context.h"
#include "content/public/test/test_browser_thread_bundle.h"
@@ -57,17 +58,14 @@ class ChromeDataUseAscriberTest : public testing::Test {
context()->CreateRequest(GURL(url), net::IDLE, nullptr);
// TODO(kundaji): Allow request_id to be specified in AllocateForTesting.
content::ResourceRequestInfo::AllocateForTesting(
- request.get(),
- content::RESOURCE_TYPE_MAIN_FRAME,
- resource_context(),
+ request.get(), content::RESOURCE_TYPE_MAIN_FRAME, resource_context(),
render_process_id,
-1, // render_view_id
- render_frame_id,
- is_main_frame,
- false, // parent_is_main_frame
- false, // allow_download
- true, // is_async
- false); // is_using_lofi
+ render_frame_id, is_main_frame,
+ false, // parent_is_main_frame
+ false, // allow_download
Nico 2017/01/11 01:14:47 nit: /*foo=*/ comments here too
megjablon 2017/01/12 17:56:29 Done.
+ true, // is_async
+ content::PREVIEWS_OFF);
return request;
}

Powered by Google App Engine
This is Rietveld 408576698