Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/loader/intercepting_resource_handler_unittest.cc

Issue 2484633004: Change Lo-Fi bool to bitmask to support multiple Previews types (Closed)
Patch Set: use PreviewsState everywhere Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/loader/async_resource_handler_unittest.cc ('K') | « content/browser/loader/async_resource_handler_unittest.cc ('k') | content/browser/loader/mime_sniffing_resource_handler_unittest.cc » ('j') | content/browser/loader/resource_dispatcher_host_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/intercepting_resource_handler_unittest.cc
diff --git a/content/browser/loader/intercepting_resource_handler_unittest.cc b/content/browser/loader/intercepting_resource_handler_unittest.cc
index aea758448889f75c8c3567566b91a14ccc4e7925..26792e716c5189dd76b396ed8d4521c063ffffd5 100644
--- a/content/browser/loader/intercepting_resource_handler_unittest.cc
+++ b/content/browser/loader/intercepting_resource_handler_unittest.cc
@@ -19,6 +19,7 @@
#include "content/browser/loader/resource_controller.h"
#include "content/browser/loader/test_resource_handler.h"
#include "content/public/browser/resource_request_info.h"
+#include "content/public/common/previews_state.h"
#include "content/public/common/resource_response.h"
#include "content/public/common/webplugininfo.h"
#include "content/public/test/test_browser_thread_bundle.h"
@@ -73,7 +74,7 @@ TEST_F(InterceptingResourceHandlerTest, NoSwitching) {
false, // parent_is_main_frame
true, // allow_download
true, // is_async
- false); // is_using_lofi
+ PREVIEWS_OFF); // previews_state
net::URLRequestStatus old_handler_status;
std::string old_handler_body;
@@ -142,7 +143,7 @@ TEST_F(InterceptingResourceHandlerTest, HandlerSwitchNoPayload) {
false, // parent_is_main_frame
true, // allow_download
true, // is_async
- false); // is_using_lofi
+ PREVIEWS_OFF); // previews_state
net::URLRequestStatus old_handler_status;
std::string old_handler_body;
@@ -227,7 +228,7 @@ TEST_F(InterceptingResourceHandlerTest, HandlerSwitchWithPayload) {
false, // parent_is_main_frame
true, // allow_download
true, // is_async
- false); // is_using_lofi
+ PREVIEWS_OFF); // previews_state
net::URLRequestStatus old_handler_status;
std::string old_handler_body;
@@ -323,7 +324,7 @@ TEST_F(InterceptingResourceHandlerTest, OldHandlerFailsWillRead) {
false, // parent_is_main_frame
true, // allow_download
true, // is_async
- false); // is_using_lofi
+ PREVIEWS_OFF); // previews_state
net::URLRequestStatus old_handler_status;
std::string old_handler_body;
@@ -361,7 +362,7 @@ TEST_F(InterceptingResourceHandlerTest, NewHandlerFailsOnWillStart) {
false, // parent_is_main_frame
true, // allow_download
true, // is_async
- false); // is_using_lofi
+ PREVIEWS_OFF); // previews_state
net::URLRequestStatus old_handler_status;
std::string old_handler_body;
@@ -416,7 +417,7 @@ TEST_F(InterceptingResourceHandlerTest, NewHandlerFailsResponseStarted) {
false, // parent_is_main_frame
true, // allow_download
true, // is_async
- false); // is_using_lofi
+ PREVIEWS_OFF); // previews_state
net::URLRequestStatus old_handler_status;
std::string old_handler_body;
@@ -470,7 +471,7 @@ TEST_F(InterceptingResourceHandlerTest, NewHandlerFailsWillRead) {
false, // parent_is_main_frame
true, // allow_download
true, // is_async
- false); // is_using_lofi
+ PREVIEWS_OFF); // previews_state
net::URLRequestStatus old_handler_status;
std::string old_handler_body;
@@ -533,7 +534,7 @@ TEST_F(InterceptingResourceHandlerTest, NewHandlerFailsReadCompleted) {
false, // parent_is_main_frame
true, // allow_download
true, // is_async
- false); // is_using_lofi
+ PREVIEWS_OFF); // previews_state
net::URLRequestStatus old_handler_status;
std::string old_handler_body;
@@ -596,7 +597,7 @@ TEST_F(InterceptingResourceHandlerTest, DeferredOperations) {
false, // parent_is_main_frame
true, // allow_download
true, // is_async
- false); // is_using_lofi
+ PREVIEWS_OFF); // previews_state
std::unique_ptr<TestResourceController> resource_controller =
base::MakeUnique<TestResourceController>();
@@ -725,7 +726,7 @@ TEST_F(InterceptingResourceHandlerTest, CancelOldHandler) {
false, // parent_is_main_frame
true, // allow_download
true, // is_async
- false); // is_using_lofi
+ PREVIEWS_OFF); // previews_state
std::unique_ptr<TestResourceController> resource_controller =
base::MakeUnique<TestResourceController>();
@@ -765,7 +766,7 @@ TEST_F(InterceptingResourceHandlerTest, CancelNewHandler) {
false, // parent_is_main_frame
true, // allow_download
true, // is_async
- false); // is_using_lofi
+ PREVIEWS_OFF); // previews_state
std::unique_ptr<TestResourceController> resource_controller =
base::MakeUnique<TestResourceController>();
@@ -844,7 +845,7 @@ TEST_F(InterceptingResourceHandlerTest, CancelBothHandlers) {
false, // parent_is_main_frame
true, // allow_download
true, // is_async
- false); // is_using_lofi
+ PREVIEWS_OFF); // previews_state
std::unique_ptr<TestResourceController> resource_controller =
base::MakeUnique<TestResourceController>();
« content/browser/loader/async_resource_handler_unittest.cc ('K') | « content/browser/loader/async_resource_handler_unittest.cc ('k') | content/browser/loader/mime_sniffing_resource_handler_unittest.cc » ('j') | content/browser/loader/resource_dispatcher_host_browsertest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698