Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1635)

Unified Diff: content/common/navigation_params.h

Issue 2484633004: Change Lo-Fi bool to bitmask to support multiple Previews types (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/navigation_params.h
diff --git a/content/common/navigation_params.h b/content/common/navigation_params.h
index 0937e4202609deb9abcc219e0e62ffd7c4a8c2ff..5534319686a45d5f940d9e7cbc70c4a258d1a58b 100644
--- a/content/common/navigation_params.h
+++ b/content/common/navigation_params.h
@@ -26,18 +26,6 @@
namespace content {
-// The LoFi state which determines whether to add the Lo-Fi header.
-enum LoFiState {
- // Let the browser process decide whether or not to request the Lo-Fi version.
- LOFI_UNSPECIFIED = 0,
-
- // Request a normal (non-Lo-Fi) version of the resource.
- LOFI_OFF,
-
- // Request a Lo-Fi version of the resource.
- LOFI_ON,
-};
-
// PlzNavigate
// Helper function to determine if the navigation to |url| should make a request
// to the network stack. A request should not be sent for JavaScript URLs or
@@ -65,7 +53,7 @@ struct CONTENT_EXPORT CommonNavigationParams {
FrameMsg_UILoadMetricsReportType::Value report_type,
const GURL& base_url_for_data_url,
const GURL& history_url_for_data_url,
- LoFiState lofi_state,
+ int previews_state,
const base::TimeTicks& navigation_start,
std::string method,
const scoped_refptr<ResourceRequestBodyImpl>& post_data);
@@ -116,9 +104,9 @@ struct CONTENT_EXPORT CommonNavigationParams {
// Is only used with data: URLs.
GURL history_url_for_data_url;
- // Whether or not to request a LoFi version of the document or let the browser
- // decide.
- LoFiState lofi_state;
+ // Bitmask that has whether or not to request a Preview version of the
+ // document for various preview types or let the browser decide.
+ int previews_state;
// The navigationStart time exposed through the Navigation Timing API to JS.
// If this is for a browser-initiated navigation, this can override the

Powered by Google App Engine
This is Rietveld 408576698