Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1441)

Unified Diff: content/public/browser/resource_dispatcher_host_delegate.h

Issue 2484633004: Change Lo-Fi bool to bitmask to support multiple Previews types (Closed)
Patch Set: add back previews_unspecified Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/resource_dispatcher_host_delegate.h
diff --git a/content/public/browser/resource_dispatcher_host_delegate.h b/content/public/browser/resource_dispatcher_host_delegate.h
index 0e5a348e4037cf8a1a8408c25e56ce6922c789b5..0e1bf6ef6a1bda0acb54b0756de4f051420b7f34 100644
--- a/content/public/browser/resource_dispatcher_host_delegate.h
+++ b/content/public/browser/resource_dispatcher_host_delegate.h
@@ -121,10 +121,11 @@ class CONTENT_EXPORT ResourceDispatcherHostDelegate {
// TODO(maksims): Remove this once all the callers are modified.
virtual void RequestComplete(net::URLRequest* url_request);
- // Asks the embedder if Lo-Fi mode should be enabled for the given request. It
- // is only called for requests with an unspecified Lo-Fi value.
- virtual bool ShouldEnableLoFiMode(const net::URLRequest& url_request,
- content::ResourceContext* resource_context);
+ // Asks the embedder for the Previews State which says which previews should
nasko 2016/12/08 22:19:33 nit: PreviewsState
megjablon 2016/12/09 20:35:54 Done.
+ // be enabled for the given request. It is only called for requests with an
+ // unspecified Previews state of zero.
nasko 2016/12/08 22:19:33 The state is not zero, it has a meaningful name. Z
megjablon 2016/12/09 20:35:54 Done.
+ virtual int GetPreviewsState(const net::URLRequest& url_request,
nasko 2016/12/08 22:19:33 Why isn't the return value PreviewsState?
megjablon 2016/12/09 20:35:55 Done.
+ content::ResourceContext* resource_context);
// Asks the embedder for NavigationData related to this request. It is only
// called for navigation requests.

Powered by Google App Engine
This is Rietveld 408576698