Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/loader/mojo_async_resource_handler_unittest.cc

Issue 2484633004: Change Lo-Fi bool to bitmask to support multiple Previews types (Closed)
Patch Set: add back previews_unspecified Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/frame_host/render_frame_host_impl.h ('K') | « content/browser/frame_host/render_frame_host_manager_unittest.cc ('k') | content/browser/loader/resource_dispatcher_host_browsertest.cc » ('j') | content/browser/loader/resource_dispatcher_host_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/mojo_async_resource_handler_unittest.cc
diff --git a/content/browser/loader/mojo_async_resource_handler_unittest.cc b/content/browser/loader/mojo_async_resource_handler_unittest.cc
index 4ad1ba638feee4d4cf1e26c56b1bddcb22ef3832..880dd2b71f7ffed086dc56f8d3af1c6b7412fc7a 100644
--- a/content/browser/loader/mojo_async_resource_handler_unittest.cc
+++ b/content/browser/loader/mojo_async_resource_handler_unittest.cc
@@ -141,11 +141,11 @@ class TestResourceDispatcherHostDelegate final
ADD_FAILURE() << "RequestComplete should not be called.";
}
- bool ShouldEnableLoFiMode(
+ int GetPreviewsState(
nasko 2016/12/08 22:19:32 PreviewsState
megjablon 2016/12/09 20:35:54 Done.
const net::URLRequest& url_request,
content::ResourceContext* resource_context) override {
- ADD_FAILURE() << "ShouldEnableLoFiMode should not be called.";
- return false;
+ ADD_FAILURE() << "GetPreviewsState should not be called.";
+ return 0;
nasko 2016/12/08 22:19:32 Use the symbolic name - PREVIEWS_UNSPECIFIED or PR
megjablon 2016/12/09 20:35:54 Done.
}
NavigationData* GetNavigationData(net::URLRequest* request) const override {
« content/browser/frame_host/render_frame_host_impl.h ('K') | « content/browser/frame_host/render_frame_host_manager_unittest.cc ('k') | content/browser/loader/resource_dispatcher_host_browsertest.cc » ('j') | content/browser/loader/resource_dispatcher_host_browsertest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698