Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Side by Side Diff: chrome/browser/android/offline_pages/offline_page_request_job_unittest.cc

Issue 2484633004: Change Lo-Fi bool to bitmask to support multiple Previews types (Closed)
Patch Set: fix ContentResourceProviderTest Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/data_usage/tab_id_annotator_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/offline_page_request_job.h" 5 #include "chrome/browser/android/offline_pages/offline_page_request_job.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/feature_list.h" 8 #include "base/feature_list.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 12 matching lines...) Expand all
23 #include "chrome/test/base/testing_browser_process.h" 23 #include "chrome/test/base/testing_browser_process.h"
24 #include "chrome/test/base/testing_profile.h" 24 #include "chrome/test/base/testing_profile.h"
25 #include "chrome/test/base/testing_profile_manager.h" 25 #include "chrome/test/base/testing_profile_manager.h"
26 #include "components/offline_pages/core/client_namespace_constants.h" 26 #include "components/offline_pages/core/client_namespace_constants.h"
27 #include "components/offline_pages/core/offline_page_model_impl.h" 27 #include "components/offline_pages/core/offline_page_model_impl.h"
28 #include "components/previews/core/previews_decider.h" 28 #include "components/previews/core/previews_decider.h"
29 #include "components/previews/core/previews_experiments.h" 29 #include "components/previews/core/previews_experiments.h"
30 #include "content/public/browser/browser_thread.h" 30 #include "content/public/browser/browser_thread.h"
31 #include "content/public/browser/resource_request_info.h" 31 #include "content/public/browser/resource_request_info.h"
32 #include "content/public/browser/web_contents.h" 32 #include "content/public/browser/web_contents.h"
33 #include "content/public/common/previews_state.h"
33 #include "content/public/common/resource_type.h" 34 #include "content/public/common/resource_type.h"
34 #include "content/public/test/test_browser_thread_bundle.h" 35 #include "content/public/test/test_browser_thread_bundle.h"
35 #include "net/url_request/url_request.h" 36 #include "net/url_request/url_request.h"
36 #include "net/url_request/url_request_context.h" 37 #include "net/url_request/url_request_context.h"
37 #include "net/url_request/url_request_intercepting_job_factory.h" 38 #include "net/url_request/url_request_intercepting_job_factory.h"
38 #include "net/url_request/url_request_job_factory_impl.h" 39 #include "net/url_request/url_request_job_factory_impl.h"
39 #include "net/url_request/url_request_test_util.h" 40 #include "net/url_request/url_request_test_util.h"
40 #include "testing/gtest/include/gtest/gtest.h" 41 #include "testing/gtest/include/gtest/gtest.h"
41 42
42 namespace offline_pages { 43 namespace offline_pages {
(...skipping 409 matching lines...) Expand 10 before | Expand all | Expand 10 after
452 url_request_delegate_ = base::MakeUnique<TestURLRequestDelegate>( 453 url_request_delegate_ = base::MakeUnique<TestURLRequestDelegate>(
453 base::Bind(&OfflinePageRequestJobTest::ReadCompletedOnIO, 454 base::Bind(&OfflinePageRequestJobTest::ReadCompletedOnIO,
454 base::Unretained(this))); 455 base::Unretained(this)));
455 456
456 std::unique_ptr<net::URLRequest> request = 457 std::unique_ptr<net::URLRequest> request =
457 url_request_context()->CreateRequest( 458 url_request_context()->CreateRequest(
458 url, net::DEFAULT_PRIORITY, url_request_delegate_.get()); 459 url, net::DEFAULT_PRIORITY, url_request_delegate_.get());
459 request->set_method(method); 460 request->set_method(method);
460 461
461 content::ResourceRequestInfo::AllocateForTesting( 462 content::ResourceRequestInfo::AllocateForTesting(
462 request.get(), 463 request.get(), resource_type, nullptr, /*render_process_id=*/1,
463 resource_type, 464 /*render_view_id=*/-1,
464 nullptr, 465 /*render_frame_id=*/1,
465 1, /* render_process_id */ 466 /*is_main_frame=*/true,
466 -1, /* render_view_id */ 467 /*parent_is_main_frame=*/false,
467 1, /* render_frame_id */ 468 /*allow_download=*/true,
468 true, /* is_main_frame */ 469 /*is_async=*/true, content::PREVIEWS_OFF);
469 false, /* parent_is_main_frame */
470 true, /* allow_download */
471 true, /* is_async */
472 false /* is_using_lofi */);
473 470
474 return request; 471 return request;
475 } 472 }
476 473
477 void 474 void
478 OfflinePageRequestJobTest::ExpectOneUniqueSampleForAggregatedRequestResult( 475 OfflinePageRequestJobTest::ExpectOneUniqueSampleForAggregatedRequestResult(
479 OfflinePageRequestJob::AggregatedRequestResult result) { 476 OfflinePageRequestJob::AggregatedRequestResult result) {
480 histogram_tester_.ExpectUniqueSample( 477 histogram_tester_.ExpectUniqueSample(
481 kAggregatedRequestResultHistogram, static_cast<int>(result), 1); 478 kAggregatedRequestResultHistogram, static_cast<int>(result), 1);
482 } 479 }
(...skipping 417 matching lines...) Expand 10 before | Expand all | Expand 10 after
900 ASSERT_TRUE(offline_page_tab_helper()->GetOfflinePageForTest()); 897 ASSERT_TRUE(offline_page_tab_helper()->GetOfflinePageForTest());
901 EXPECT_EQ(offline_id4(), 898 EXPECT_EQ(offline_id4(),
902 offline_page_tab_helper()->GetOfflinePageForTest()->offline_id); 899 offline_page_tab_helper()->GetOfflinePageForTest()->offline_id);
903 ExpectOneUniqueSampleForAggregatedRequestResult( 900 ExpectOneUniqueSampleForAggregatedRequestResult(
904 OfflinePageRequestJob::AggregatedRequestResult:: 901 OfflinePageRequestJob::AggregatedRequestResult::
905 SHOW_OFFLINE_ON_DISCONNECTED_NETWORK); 902 SHOW_OFFLINE_ON_DISCONNECTED_NETWORK);
906 ExpectOpenFileErrorCode(net::ERR_FILE_NOT_FOUND); 903 ExpectOpenFileErrorCode(net::ERR_FILE_NOT_FOUND);
907 } 904 }
908 905
909 } // namespace offline_pages 906 } // namespace offline_pages
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/data_usage/tab_id_annotator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698