Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: chrome/browser/net/spdyproxy/chrome_data_use_group_provider_unittest.cc

Issue 2484633004: Change Lo-Fi bool to bitmask to support multiple Previews types (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/net/spdyproxy/chrome_data_use_group_provider.h" 5 #include "chrome/browser/net/spdyproxy/chrome_data_use_group_provider.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "chrome/browser/net/spdyproxy/chrome_data_use_group.h" 10 #include "chrome/browser/net/spdyproxy/chrome_data_use_group.h"
11 #include "content/public/browser/resource_request_info.h" 11 #include "content/public/browser/resource_request_info.h"
12 #include "content/public/common/previews_state.h"
12 #include "content/public/test/test_browser_thread_bundle.h" 13 #include "content/public/test/test_browser_thread_bundle.h"
13 #include "net/url_request/url_request.h" 14 #include "net/url_request/url_request.h"
14 #include "net/url_request/url_request_test_util.h" 15 #include "net/url_request/url_request_test_util.h"
15 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
16 #include "url/gurl.h" 17 #include "url/gurl.h"
17 18
18 class ChromeDataUseGroupProviderTest : public testing::Test { 19 class ChromeDataUseGroupProviderTest : public testing::Test {
19 protected: 20 protected:
20 ChromeDataUseGroupProvider* data_use_group_provider() { 21 ChromeDataUseGroupProvider* data_use_group_provider() {
21 return &data_use_group_provider_; 22 return &data_use_group_provider_;
22 } 23 }
23 24
24 std::unique_ptr<net::URLRequest> CreateRequestForFrame(int render_process_id, 25 std::unique_ptr<net::URLRequest> CreateRequestForFrame(int render_process_id,
25 int render_frame_id) { 26 int render_frame_id) {
26 std::unique_ptr<net::URLRequest> request = context_.CreateRequest( 27 std::unique_ptr<net::URLRequest> request = context_.CreateRequest(
27 GURL("http://foo.com/"), net::IDLE, &test_delegate_); 28 GURL("http://foo.com/"), net::IDLE, &test_delegate_);
28 29
29 content::ResourceRequestInfo::AllocateForTesting( 30 content::ResourceRequestInfo::AllocateForTesting(
30 request.get(), content::RESOURCE_TYPE_MAIN_FRAME, 31 request.get(), content::RESOURCE_TYPE_MAIN_FRAME,
31 nullptr, /* ResourceContext */ 32 nullptr, /* ResourceContext */
32 render_process_id, -1, /* render_view_id */ 33 render_process_id, -1, /* render_view_id */
33 render_frame_id, true, /* is_main_frame */ 34 render_frame_id, true, /* is_main_frame */
34 false, /* parent_is_main_frame */ 35 false, /* parent_is_main_frame */
35 true, /* allow_download */ 36 true, /* allow_download */
36 true, /* is_async */ 37 true, /* is_async */
37 false /* is_using_lofi */); 38 content::PREVIEWS_OFF /* previews_state */);
Nico 2017/01/09 22:35:03 ditto
megjablon 2017/01/10 22:30:01 Done.
38 39
39 return request; 40 return request;
40 } 41 }
41 42
42 private: 43 private:
43 // |thread_bundle_| must be the first field to ensure that threads are 44 // |thread_bundle_| must be the first field to ensure that threads are
44 // constructed first and destroyed last. 45 // constructed first and destroyed last.
45 content::TestBrowserThreadBundle thread_bundle_; 46 content::TestBrowserThreadBundle thread_bundle_;
46 47
47 net::TestURLRequestContext context_; 48 net::TestURLRequestContext context_;
(...skipping 17 matching lines...) Expand all
65 std::unique_ptr<net::URLRequest> request = CreateRequestForFrame(1, 1); 66 std::unique_ptr<net::URLRequest> request = CreateRequestForFrame(1, 1);
66 scoped_refptr<data_reduction_proxy::DataUseGroup> group1 = 67 scoped_refptr<data_reduction_proxy::DataUseGroup> group1 =
67 data_use_group_provider()->GetDataUseGroup(request.get()); 68 data_use_group_provider()->GetDataUseGroup(request.get());
68 69
69 request = CreateRequestForFrame(2, 2); 70 request = CreateRequestForFrame(2, 2);
70 scoped_refptr<data_reduction_proxy::DataUseGroup> group2 = 71 scoped_refptr<data_reduction_proxy::DataUseGroup> group2 =
71 data_use_group_provider()->GetDataUseGroup(request.get()); 72 data_use_group_provider()->GetDataUseGroup(request.get());
72 73
73 EXPECT_NE(group1, group2); 74 EXPECT_NE(group1, group2);
74 } 75 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698