Change Lo-Fi bool to bitmask to support multiple Previews types

chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <memory>
 
 #include "base/macros.h"
 #include "base/message_loop/message_loop.h"
 #include "chrome/common/extensions/extension_test_util.h"
 #include "chromeos/login/login_state.h"
 #include "content/public/browser/resource_request_info.h"
+#include "content/public/common/previews_state.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "extensions/browser/api/web_request/web_request_permissions.h"
 #include "extensions/browser/info_map.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/permissions/permissions_data.h"
 #include "ipc/ipc_message.h"
 #include "net/base/request_priority.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 120 matching lines @@
       context.CreateRequest(non_sensitive_url, net::DEFAULT_PRIORITY, NULL));
   EXPECT_FALSE(WebRequestPermissions::HideRequest(
       extension_info_map_.get(), non_sensitive_request.get(), nullptr));
   // If the origin is labeled by the WebStoreAppId, it becomes protected.
   {
     int process_id = 42;
     int site_instance_id = 23;
     int view_id = 17;
     std::unique_ptr<net::URLRequest> sensitive_request(
         context.CreateRequest(non_sensitive_url, net::DEFAULT_PRIORITY, NULL));
-    ResourceRequestInfo::AllocateForTesting(sensitive_request.get(),
-                                            content::RESOURCE_TYPE_SCRIPT,
-                                            NULL,
-                                            process_id,
-                                            view_id,
-                                            MSG_ROUTING_NONE,
-                                            false,   // is_main_frame
-                                            false,   // parent_is_main_frame
-                                            true,    // allow_download
-                                            false,   // is_async
-                                            false);  // is_using_lofi
+    ResourceRequestInfo::AllocateForTesting(
+        sensitive_request.get(), content::RESOURCE_TYPE_SCRIPT, NULL,
+        process_id, view_id, MSG_ROUTING_NONE,
+        false,                   // is_main_frame
+        false,                   // parent_is_main_frame
+        true,                    // allow_download
+        false,                   // is_async
+        content::PREVIEWS_OFF);  // previews_state

[Nico, 2017/01/09 22:35:03]

likewise; also like in the other places consider /*foo=*/ prefix comments
instead

[megjablon, 2017/01/10 22:30:01]

Done.

     extension_info_map_->RegisterExtensionProcess(
         extensions::kWebStoreAppId, process_id, site_instance_id);
     EXPECT_TRUE(WebRequestPermissions::HideRequest(
         extension_info_map_.get(), sensitive_request.get(), nullptr));
   }
 }
 
 TEST_F(ExtensionWebRequestHelpersTestWithThreadsTest,
        TestCanExtensionAccessURL_HostPermissions) {
   std::unique_ptr<net::URLRequest> request(context.CreateRequest(
@@ skipping 70 matching lines @@
 
   EXPECT_EQ(PermissionsData::ACCESS_DENIED,
             WebRequestPermissions::CanExtensionAccessURL(
                 extension_info_map_.get(), com_policy_extension_->id(),
                 chrome_request->url(),
                 -1,  // No tab id.
                 false, // crosses_incognito
                 WebRequestPermissions::REQUIRE_HOST_PERMISSION));
 #endif
 }