content/public/common/previews_state.h - Issue 2484633004: Change Lo-Fi bool to bitmask to support multiple Previews types

Side by Side Diff: content/public/common/previews_state.h

Issue 2484633004: Change Lo-Fi bool to bitmask to support multiple Previews types (Closed)

Patch Set: add back previews_unspecified Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« content/public/browser/resource_request_info.h ('K') | « content/public/common/BUILD.gn ('k') | content/public/common/resource_response.cc » ('j') | content/public/common/resource_response_info.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_PUBLIC_COMMON_PREVIEWS_TYPE_H_

	6 #define CONTENT_PUBLIC_COMMON_PREVIEWS_TYPE_H_

	7

	8 #include "content/common/content_export.h"

	9

	10 namespace content {

	11

	12 // The Previews state which determines whether to request a Preview version of

	13 // the resource.
	nasko 2016/12/08 22:19:33 Please explain a bit more what Previews is. As it Please explain a bit more what Previews is. As it is, the comment doesn't give me a good idea of what it is. Alternatively, point to a publicly accessible design document explaining the concept. megjablon 2016/12/09 20:35:55 I added the description we use elsewhere. There is Show quoted text On 2016/12/08 22:19:33, nasko (very slow til Dec 13th) wrote: > Please explain a bit more what Previews is. As it is, the comment doesn't give > me a good idea of what it is. > Alternatively, point to a publicly accessible design document explaining the > concept. I added the description we use elsewhere. There isn't a public design doc, and since I'm not the owner I can't change the access.
	14 enum PreviewsState {
	nasko 2016/12/08 22:19:33 Honestly, Previews does not convey to me the meani Honestly, Previews does not convey to me the meaning of what LoFi does. megjablon 2016/12/09 20:35:55 Lo-Fi is a type of Preview. Lo-Fi used to be the o Show quoted text On 2016/12/08 22:19:33, nasko (very slow til Dec 13th) wrote: > Honestly, Previews does not convey to me the meaning of what LoFi does. Lo-Fi is a type of Preview. Lo-Fi used to be the only optimization of it's kind, but we're working on other page optimizations that all fit into this same category. Previews are optimizations that change the format and content of web pages to improve data savings and / or performance. They can be applied individually or in combination. This enum will soon include Lite Pages, which are currently just using the Lo-Fi bool, but should be considered their own optimization. Other preview types will also be showing an offline page on slow connections and possibly javascript disable.
	15 PREVIEWS_UNSPECIFIED = 0, // Let the browser process decide whether or

	16 // not to request Preview types.

	17 SERVER_LOFI_ON = 1 << 0, // Request a Lo-Fi version of the resource
	nasko 2016/12/08 22:19:33 Shouldn't the members be named using Previews inst Shouldn't the members be named using Previews instead of LoFi? Having both names commingled leads to confusion. megjablon 2016/12/09 20:35:55 These are the previews types that can be applied i Show quoted text On 2016/12/08 22:19:33, nasko (very slow til Dec 13th) wrote: > Shouldn't the members be named using Previews instead of LoFi? Having both names > commingled leads to confusion. These are the previews types that can be applied individually or in combination.
	18 // from the server.

	19 CLIENT_LOFI_ON = 1 << 1, // Request a Lo-Fi version of the resource

	20 // from the client.

	21 PREVIEWS_OFF = 1 << 2 // Request a normal (non-Preview) version of

	22 // the resource.

	23 };

	24

	25 } // namespace content

	26

	27 #endif // CONTENT_PUBLIC_COMMON_PREVIEWS_TYPE_H_

OLD	NEW