Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 2484633004: Change Lo-Fi bool to bitmask to support multiple Previews types (Closed)
Patch Set: add back previews_unspecified Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 551 matching lines...) Expand 10 before | Expand all | Expand 10 after
562 void ResetLoadingState(); 562 void ResetLoadingState();
563 563
564 // Tells the renderer that this RenderFrame will soon be swapped out, and thus 564 // Tells the renderer that this RenderFrame will soon be swapped out, and thus
565 // not to create any new modal dialogs until it happens. This must be done 565 // not to create any new modal dialogs until it happens. This must be done
566 // separately so that the ScopedPageLoadDeferrers of any current dialogs are 566 // separately so that the ScopedPageLoadDeferrers of any current dialogs are
567 // no longer on the stack when we attempt to swap it out. 567 // no longer on the stack when we attempt to swap it out.
568 void SuppressFurtherDialogs(); 568 void SuppressFurtherDialogs();
569 569
570 void SetHasReceivedUserGesture(); 570 void SetHasReceivedUserGesture();
571 571
572 // PlzNavigate: returns the LoFi state of the last successful navigation that 572 // PlzNavigate: returns the Previews state of the last successful navigation
573 // made a network request. 573 // that made a network request.
574 LoFiState last_navigation_lofi_state() const { 574 int last_navigation_previews_state() const {
nasko 2016/12/08 22:19:32 PreviewsState
megjablon 2016/12/09 20:35:54 Done.
575 return last_navigation_lofi_state_; 575 return last_navigation_previews_state_;
576 } 576 }
577 577
578 protected: 578 protected:
579 friend class RenderFrameHostFactory; 579 friend class RenderFrameHostFactory;
580 580
581 // |flags| is a combination of CreateRenderFrameFlags. 581 // |flags| is a combination of CreateRenderFrameFlags.
582 // TODO(nasko): Remove dependency on RenderViewHost here. RenderProcessHost 582 // TODO(nasko): Remove dependency on RenderViewHost here. RenderProcessHost
583 // should be the abstraction needed here, but we need RenderViewHost to pass 583 // should be the abstraction needed here, but we need RenderViewHost to pass
584 // into WebContentsObserver::FrameDetached for now. 584 // into WebContentsObserver::FrameDetached for now.
585 RenderFrameHostImpl(SiteInstance* site_instance, 585 RenderFrameHostImpl(SiteInstance* site_instance,
(...skipping 451 matching lines...) Expand 10 before | Expand all | Expand 10 after
1037 std::unique_ptr<WebUIImpl> pending_web_ui_; 1037 std::unique_ptr<WebUIImpl> pending_web_ui_;
1038 WebUI::TypeID pending_web_ui_type_; 1038 WebUI::TypeID pending_web_ui_type_;
1039 1039
1040 // If true the associated WebUI should be reused when CommitPendingWebUI is 1040 // If true the associated WebUI should be reused when CommitPendingWebUI is
1041 // called (no pending instance should be set). 1041 // called (no pending instance should be set).
1042 bool should_reuse_web_ui_; 1042 bool should_reuse_web_ui_;
1043 1043
1044 // If true, then the RenderFrame has selected text. 1044 // If true, then the RenderFrame has selected text.
1045 bool has_selection_; 1045 bool has_selection_;
1046 1046
1047 // PlzNavigate: The LoFi state of the last navigation. This is used during 1047 // PlzNavigate: The Previews state of the last navigation. This is used during
1048 // history navigation of subframes to ensure that subframes navigate with the 1048 // history navigation of subframes to ensure that subframes navigate with the
1049 // same LoFi status as the top-level frame. 1049 // same Previews status as the top-level frame.
1050 LoFiState last_navigation_lofi_state_; 1050 int last_navigation_previews_state_;
nasko 2016/12/08 22:19:32 PreviewsState
megjablon 2016/12/09 20:35:54 Done.
1051 1051
1052 mojo::Binding<mojom::FrameHost> frame_host_binding_; 1052 mojo::Binding<mojom::FrameHost> frame_host_binding_;
1053 mojom::FramePtr frame_; 1053 mojom::FramePtr frame_;
1054 1054
1055 // If this is true then this object was created in response to a renderer 1055 // If this is true then this object was created in response to a renderer
1056 // initiated request. Init() will be called, and until then navigation 1056 // initiated request. Init() will be called, and until then navigation
1057 // requests should be queued. 1057 // requests should be queued.
1058 bool waiting_for_init_; 1058 bool waiting_for_init_;
1059 1059
1060 typedef std::pair<CommonNavigationParams, BeginNavigationParams> 1060 typedef std::pair<CommonNavigationParams, BeginNavigationParams>
(...skipping 11 matching lines...) Expand all
1072 remote_associated_interfaces_; 1072 remote_associated_interfaces_;
1073 // NOTE: This must be the last member. 1073 // NOTE: This must be the last member.
1074 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_; 1074 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
1075 1075
1076 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 1076 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
1077 }; 1077 };
1078 1078
1079 } // namespace content 1079 } // namespace content
1080 1080
1081 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 1081 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698