Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3830)

Unified Diff: chrome/browser/extensions/extension_service_sync_unittest.cc

Issue 2484613002: Migrate more tests to ScopedFeatureList. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service_sync_unittest.cc
diff --git a/chrome/browser/extensions/extension_service_sync_unittest.cc b/chrome/browser/extensions/extension_service_sync_unittest.cc
index 56f7fc0a2b26a99b3d9b4ddb18be223126b0849e..5cfc3876ae3629b5f32e8fbbf4eb871301db4e28 100644
--- a/chrome/browser/extensions/extension_service_sync_unittest.cc
+++ b/chrome/browser/extensions/extension_service_sync_unittest.cc
@@ -11,13 +11,13 @@
#include "base/bind.h"
#include "base/command_line.h"
-#include "base/feature_list.h"
#include "base/files/file_util.h"
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/memory/weak_ptr.h"
#include "base/metrics/field_trial.h"
#include "base/test/mock_entropy_provider.h"
+#include "base/test/scoped_feature_list.h"
#include "chrome/browser/extensions/api/webstore_private/webstore_private_api.h"
#include "chrome/browser/extensions/component_loader.h"
#include "chrome/browser/extensions/extension_service.h"
@@ -1583,13 +1583,10 @@ class ExtensionServiceTestSupervised : public ExtensionServiceSyncTest,
protected:
void InitSupervisedUserInitiatedExtensionInstallFeature(bool enabled) {
- base::FeatureList::ClearInstanceForTesting();
- std::unique_ptr<base::FeatureList> feature_list(new base::FeatureList);
if (enabled) {
- feature_list->InitializeFromCommandLine(
- "SupervisedUserInitiatedExtensionInstall", std::string());
+ scoped_feature_list_.InitAndEnableFeature(
+ supervised_users::kSupervisedUserInitiatedExtensionInstall);
}
- base::FeatureList::SetInstance(std::move(feature_list));
}
bool IsPendingCustodianApproval(const std::string& extension_id) {
@@ -1738,6 +1735,7 @@ class ExtensionServiceTestSupervised : public ExtensionServiceSyncTest,
}
base::FieldTrialList field_trial_list_;
+ base::test::ScopedFeatureList scoped_feature_list_;
};
class MockPermissionRequestCreator : public PermissionRequestCreator {

Powered by Google App Engine
This is Rietveld 408576698