Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Side by Side Diff: content/child/resource_dispatcher_unittest.cc

Issue 2484613002: Migrate more tests to ScopedFeatureList. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/child/resource_dispatcher.h" 5 #include "content/child/resource_dispatcher.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
11 #include <string> 11 #include <string>
12 #include <tuple> 12 #include <tuple>
13 #include <utility> 13 #include <utility>
14 #include <vector> 14 #include <vector>
15 15
16 #include "base/feature_list.h"
17 #include "base/macros.h" 16 #include "base/macros.h"
18 #include "base/memory/ptr_util.h" 17 #include "base/memory/ptr_util.h"
19 #include "base/memory/shared_memory.h" 18 #include "base/memory/shared_memory.h"
20 #include "base/message_loop/message_loop.h" 19 #include "base/message_loop/message_loop.h"
21 #include "base/process/process_handle.h" 20 #include "base/process/process_handle.h"
22 #include "base/run_loop.h" 21 #include "base/run_loop.h"
22 #include "base/test/scoped_feature_list.h"
23 #include "content/child/request_extra_data.h" 23 #include "content/child/request_extra_data.h"
24 #include "content/common/appcache_interfaces.h" 24 #include "content/common/appcache_interfaces.h"
25 #include "content/common/resource_messages.h" 25 #include "content/common/resource_messages.h"
26 #include "content/common/resource_request.h" 26 #include "content/common/resource_request.h"
27 #include "content/common/resource_request_completion_status.h" 27 #include "content/common/resource_request_completion_status.h"
28 #include "content/common/service_worker/service_worker_types.h" 28 #include "content/common/service_worker/service_worker_types.h"
29 #include "content/public/child/fixed_received_data.h" 29 #include "content/public/child/fixed_received_data.h"
30 #include "content/public/child/request_peer.h" 30 #include "content/public/child/request_peer.h"
31 #include "content/public/child/resource_dispatcher_delegate.h" 31 #include "content/public/child/resource_dispatcher_delegate.h"
32 #include "content/public/common/content_features.h" 32 #include "content/public/common/content_features.h"
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
372 EXPECT_EQ(0u, queued_messages()); 372 EXPECT_EQ(0u, queued_messages());
373 373
374 NotifyRequestComplete(id, strlen(kTestPageContents)); 374 NotifyRequestComplete(id, strlen(kTestPageContents));
375 EXPECT_EQ(kTestPageContents, peer_context.data); 375 EXPECT_EQ(kTestPageContents, peer_context.data);
376 EXPECT_TRUE(peer_context.complete); 376 EXPECT_TRUE(peer_context.complete);
377 EXPECT_EQ(0u, queued_messages()); 377 EXPECT_EQ(0u, queued_messages());
378 } 378 }
379 379
380 // A simple request with an inline data response. 380 // A simple request with an inline data response.
381 TEST_F(ResourceDispatcherTest, ResponseWithInlinedData) { 381 TEST_F(ResourceDispatcherTest, ResponseWithInlinedData) {
382 auto feature_list = base::MakeUnique<base::FeatureList>(); 382 base::test::ScopedFeatureList scoped_feature_list;
383 feature_list->InitializeFromCommandLine( 383 scoped_feature_list.InitAndEnableFeature(
384 features::kOptimizeLoadingIPCForSmallResources.name, std::string()); 384 features::kOptimizeLoadingIPCForSmallResources);
385 base::FeatureList::ClearInstanceForTesting(); 385
386 base::FeatureList::SetInstance(std::move(feature_list));
387 std::unique_ptr<ResourceRequest> request(CreateResourceRequest(false)); 386 std::unique_ptr<ResourceRequest> request(CreateResourceRequest(false));
388 TestRequestPeer::Context peer_context; 387 TestRequestPeer::Context peer_context;
389 StartAsync(std::move(request), NULL, &peer_context); 388 StartAsync(std::move(request), NULL, &peer_context);
390 389
391 int id = ConsumeRequestResource(); 390 int id = ConsumeRequestResource();
392 EXPECT_EQ(0u, queued_messages()); 391 EXPECT_EQ(0u, queued_messages());
393 392
394 NotifyReceivedResponse(id); 393 NotifyReceivedResponse(id);
395 EXPECT_EQ(0u, queued_messages()); 394 EXPECT_EQ(0u, queued_messages());
396 EXPECT_TRUE(peer_context.received_response); 395 EXPECT_TRUE(peer_context.received_response);
(...skipping 641 matching lines...) Expand 10 before | Expand all | Expand 10 after
1038 ResourceResponseHead response_head; 1037 ResourceResponseHead response_head;
1039 1038
1040 PerformTest(response_head); 1039 PerformTest(response_head);
1041 1040
1042 EXPECT_EQ(base::TimeTicks(), response_info().load_timing.request_start); 1041 EXPECT_EQ(base::TimeTicks(), response_info().load_timing.request_start);
1043 EXPECT_EQ(base::TimeTicks(), 1042 EXPECT_EQ(base::TimeTicks(),
1044 response_info().load_timing.connect_timing.dns_start); 1043 response_info().load_timing.connect_timing.dns_start);
1045 } 1044 }
1046 1045
1047 } // namespace content 1046 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/memory/memory_coordinator_impl_unittest.cc ('k') | media/blink/webmediaplayer_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698