Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2484453002: Remove unused CFX_QuartzDevice(Driver) classes. (Closed)

Created:
4 years, 1 month ago by npm
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang, dsinclair, _cary
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove unused CFX_QuartzDevice(Driver) classes. Committed: https://pdfium.googlesource.com/pdfium/+/a97fc7c6392c0adbd702bdf898cb9e20cee00a3e

Patch Set 1 #

Total comments: 6

Patch Set 2 : Remove unneeded #if's #

Patch Set 3 : Rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1085 lines) Patch
M BUILD.gn View 1 2 3 chunks +12 lines, -5 lines 0 comments Download
M core/fxge/apple/apple_int.h View 1 2 2 chunks +0 lines, -104 lines 1 comment Download
D core/fxge/apple/cfx_quartzdevice.h View 2 1 chunk +0 lines, -31 lines 0 comments Download
M core/fxge/apple/fx_apple_platform.cpp View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M core/fxge/apple/fx_mac_imp.cpp View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M core/fxge/apple/fx_quartz_device.cpp View 1 2 5 chunks +13 lines, -936 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
npm
PTAL
4 years, 1 month ago (2016-11-05 01:17:31 UTC) #4
dsinclair
lgtm w/ nits https://codereview.chromium.org/2484453002/diff/1/core/fxge/apple/apple_int.h File core/fxge/apple/apple_int.h (right): https://codereview.chromium.org/2484453002/diff/1/core/fxge/apple/apple_int.h#newcode12 core/fxge/apple/apple_int.h:12: #if _FXM_PLATFORM_ == _FXM_PLATFORM_APPLE_ nit: Can ...
4 years, 1 month ago (2016-11-07 14:25:03 UTC) #7
npm
https://codereview.chromium.org/2484453002/diff/1/core/fxge/apple/apple_int.h File core/fxge/apple/apple_int.h (right): https://codereview.chromium.org/2484453002/diff/1/core/fxge/apple/apple_int.h#newcode12 core/fxge/apple/apple_int.h:12: #if _FXM_PLATFORM_ == _FXM_PLATFORM_APPLE_ On 2016/11/07 14:25:03, dsinclair wrote: ...
4 years, 1 month ago (2016-11-07 16:02:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484453002/40001
4 years, 1 month ago (2016-11-07 16:02:53 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 16:50:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/a97fc7c6392c0adbd702bdf898cb9e20cee0...

Powered by Google App Engine
This is Rietveld 408576698