Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2484433002: Revert of fix swarmbucket infra path (Closed)

Created:
4 years, 1 month ago by martiniss
Modified:
4 years, 1 month ago
Reviewers:
Vadim Sh., nodir
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of fix swarmbucket infra path (patchset #3 id:40001 of https://codereview.chromium.org/2477033002/ ) Reason for revert: Broke build CQ: https://luci-milo.appspot.com/swarming/task/324a5636a5cfdf10/steps/Uncaught_Exception/0/logs/exception/0 Original issue's description: > fix swarmbucket infra path > > Do not rely on buildbot config which goes up 4 directories. Everything > should happen in the workdir. Also exclude any project-specific paths. > > This fixes the problem that swarmbucket builds expect git_cache to be in > /b/git_cache. It should be in the CWD/git_cache. This will fix Windows > builders. > > R=vadimsh@chromium.org > BUG= > > Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/b8b5aaea9217f0a2e0b9a48bfa6e6fc054d74d23 TBR=vadimsh@chromium.org,nodir@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/5da21889e50dd98d60db7dfe6aeb7fbb17f202ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M recipe_modules/infra_paths/example.py View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/infra_paths/example.expected/basic.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/infra_paths/example.expected/paths_buildbot_linux.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/infra_paths/example.expected/paths_buildbot_mac.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/infra_paths/example.expected/paths_buildbot_win.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/infra_paths/example.expected/paths_kitchen_linux.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/infra_paths/example.expected/paths_kitchen_mac.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/infra_paths/example.expected/paths_kitchen_win.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/infra_paths/example.expected/paths_swarmbucket_linux.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/infra_paths/example.expected/paths_swarmbucket_mac.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/infra_paths/example.expected/paths_swarmbucket_win.json View 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/infra_paths/path_config.py View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
martiniss
Created Revert of fix swarmbucket infra path
4 years, 1 month ago (2016-11-04 22:51:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484433002/1
4 years, 1 month ago (2016-11-04 22:51:09 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 22:51:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/5da21889e50dd9...

Powered by Google App Engine
This is Rietveld 408576698