chrome/browser/resources/settings/site_settings_page/site_settings_page.js - Issue 2484423004: [MD settings] settings for pdf documents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings_page/site_settings_page.js

Issue 2484423004: [MD settings] settings for pdf documents (Closed)

Patch Set: unit test fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/site_settings_page/site_settings_page.html ('k') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings_page/site_settings_page.js

diff --git a/chrome/browser/resources/settings/site_settings_page/site_settings_page.js b/chrome/browser/resources/settings/site_settings_page/site_settings_page.js

index e66fcd7a41ce91bf9b83053e891ef468669d0d68..773a22180b6f4e3d0b58a94b4f0588c11fbe8c3c 100644

--- a/chrome/browser/resources/settings/site_settings_page/site_settings_page.js

+++ b/chrome/browser/resources/settings/site_settings_page/site_settings_page.js

@@ -78,4 +78,13 @@ Polymer({

else

settings.navigateTo(this.computeCategoryRoute(category));

+ /**

+ * Navigate to the route specified in the event dataset.

+ * @param {!Event} event The tap event.

+ */

+ onTapNavigate: function(event) {

dpapad 2016/11/15 00:32:46 Can this be private?

dschuyler 2016/11/15 01:29:43 Done.

+ var dataSet = /** @type {{route: string}} */(event.currentTarget.dataset);

+ settings.navigateTo(settings.Route[dataSet.route]);

+ },

});