chrome/browser/resources/settings/site_settings/pdf_documents.html - Issue 2484423004: [MD settings] settings for pdf documents

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/site_settings/pdf_documents.html

Issue 2484423004: [MD settings] settings for pdf documents (Closed)

Patch Set: touch ups Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2 <link rel="import" href="/controls/settings_toggle_button.html">

	3 <link rel="import" href="/settings_shared_css.html">

	4

	5 <dom-module id="pdf-documents">
	dpapad 2016/11/11 22:28:03 Nit: Should this element be named settings-pdf-doc Nit: Should this element be named settings-pdf-documents. I know that site_settings/ has not followed that pattern as closely as the rest of the codebase, so consider this optional (and probably better done as a cleanup throughout site_settings/ later). dschuyler 2016/11/12 00:11:53 Done. Show quoted text On 2016/11/11 22:28:03, dpapad wrote: > Nit: Should this element be named settings-pdf-documents. I know that > site_settings/ has not followed that pattern as closely as the rest of the > codebase, so consider this optional (and probably better done as a cleanup > throughout site_settings/ later). Done.
	6 <template>

	7 <style include="settings-shared"></style>

	8 <div class="settings-box first two-line">

	9 <div class="start secondary">

	10 $i18n{siteSettingsPdfDefaultViewer}

	11 </div>

	12 <settings-toggle-button id="toggle" checked="{{categoryEnabled}}"

	13 inverted on-change="onToggleChange_"

	14 pref="{{prefs.plugins.always_open_pdf_externally}}">

	15 </settings-toggle-button>

	16 </div>

	17 </template>

	18 <script src="pdf_documents.js"></script>

	19 </dom-module>

OLD	NEW