[MD settings] settings for pdf documents

chrome/app/settings_strings.grdp

 <?xml version="1.0" encoding="utf-8"?>
 <!-- Settings-specific strings (included from generated_resources.grd). -->
 <grit-part>
   <!-- About Page -->
   <if expr="chromeos">
     <message name="IDS_SETTINGS_ABOUT_PAGE_DETAILED_BUILD_INFO" desc="Label describing the section that shows detailed information about the current Chrome build.">
       Detailed build information
     </message>
     <message name="IDS_SETTINGS_ABOUT_PAGE_ARC_VERSION" desc="Label for ARC version">
       ARC Version
@@ skipping 1646 matching lines @@
   </message>
   <message name="IDS_SETTINGS_SITE_SETTINGS_IMAGES" desc="Label for the images site settings.">
     Images
   </message>
   <message name="IDS_SETTINGS_SITE_SETTINGS_JAVASCRIPT" desc="Label for the javascript site settings.">
     Javascript
   </message>
   <message name="IDS_SETTINGS_SITE_SETTINGS_FLASH" desc="Label for the Flash site settings.">
     Flash
   </message>
+  <message name="IDS_SETTINGS_SITE_SETTINGS_PDF_DOCUMENTS" desc="Label for the PDF documents site settings.">
+    PDF documents
+  </message>
+  <message name="IDS_SETTINGS_SITE_SETTINGS_PDF_DEFAULT_VIEWER" desc="Label for openning PDF documents using the default PDF viewer application.">

[dpapad, 2016/11/11 22:28:03]

Does this setting apply to both Chromium and Chrome?

If yes, should there be a different string for each case (in
settings_chromium_strings.grdp and settings_google_chrome_strings.grdp)?

If no, should this string be in an "<if expr=" block (and similarly within an
ifdef at md_settings_localized_strings_provider.cc)? 

[dschuyler, 2016/11/12 00:11:53]

There's another problem here. The text can give the impression that
Chrome will become the default PDF viewer (like when opening a PDF
file from the desktop, outside of the browser). That's not accurate.
I've changed the text and sent the new text to Alan for approval.
I believe the new text is good enough to go in now - I believe it's 
likely to be approved or only need a small change (which will be 
an easy CL).

+    Use Chrome as your default PDF viewer
+  </message>
   <message name="IDS_SETTINGS_SITE_SETTINGS_POPUPS" desc="Label for the popups site settings.">
     Popups
   </message>
   <message name="IDS_SETTINGS_SITE_SETTINGS_UNSANDBOXED_PLUGINS" desc="Label for the unsandboxed plugin access site settings.">
     Unsandboxed plugin access
   </message>
   <message name="IDS_SETTINGS_SITE_SETTINGS_USB_DEVICES" desc="Label for the USB devices in site settings.">
     USB devices
   </message>
   <message name="IDS_SETTINGS_SITE_SETTINGS_FULLSCREEN" desc="Label for the fullscreen site settings.">
@@ skipping 880 matching lines @@
       System
     </message>
     <message name="IDS_SETTINGS_SYSTEM_HARDWARE_ACCELERATION_LABEL" desc="Label for the checkbox that forces Chrome to render via hardware acceleration (GPU) when available.">
       Use hardware acceleration when available
     </message>
     <message name="IDS_SETTINGS_SYSTEM_PROXY_SETTINGS_BUTTON" desc="Text for the button that changes a user's network proxy settings.">
       Change proxy settings
     </message>
   </if>
 </grit-part>