Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/browser/api/app_window/app_window_api.cc

Issue 2484413002: Enhance chrome.app.window API with title property
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc ('K') | « chrome/browser/ui/ash/launcher/launcher_item_controller.cc ('k') | extensions/browser/app_window/app_window.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/app_window/app_window_api.cc
diff --git a/extensions/browser/api/app_window/app_window_api.cc b/extensions/browser/api/app_window/app_window_api.cc
index e92e7e7f659ecd0b5430033481aafe7020d6f6ea..f11bb02b6ce00c2b534a931fd6b8b00a19b523da 100644
--- a/extensions/browser/api/app_window/app_window_api.cc
+++ b/extensions/browser/api/app_window/app_window_api.cc
@@ -343,6 +343,9 @@ bool AppWindowCreateFunction::RunAsync() {
}
}
+ if (options->title.get())
+ create_params.title = *options->title;
+
if (options->type != app_window::WINDOW_TYPE_PANEL) {
switch (options->state) {
case app_window::STATE_NONE:
« chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc ('K') | « chrome/browser/ui/ash/launcher/launcher_item_controller.cc ('k') | extensions/browser/app_window/app_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698