Unflake AppViewTest.TestAppViewGoodDataShouldSucceed under UBSan Vptr.

Unflake AppViewTest.TestAppViewGoodDataShouldSucceed under UBSan Vptr.

Sometimes (when Chromium is being deleted), ExtensionsBrowserClient::Get() could return NULL.
This fix avoids calling a virtual method on a null pointer, deflaking the test
under UBSan Vptr. See the bug attached for more details.

BUG=663552
Committed: https://crrev.com/b72974798e11b6cffe236f746c3a778ddeba57b5
Cr-Commit-Position: refs/heads/master@{#430830}

[krasin1, 2016-11-08 23:55:15]

The CQ bit was checked by krasin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 23:56:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[krasin1, 2016-11-08 23:56:40]

krasin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[lazyboy, 2016-11-09 00:10:11]

lgtm

https://codereview.chromium.org/2484353002/diff/1/extensions/browser/api/web_...
File extensions/browser/api/web_request/web_request_api.cc (right):

https://codereview.chromium.org/2484353002/diff/1/extensions/browser/api/web_...
extensions/browser/api/web_request/web_request_api.cc:971: if (!client) {
I'd add a comment here saying |client| could be null during shutdown.

[krasin1, 2016-11-09 00:36:05]

https://codereview.chromium.org/2484353002/diff/1/extensions/browser/api/web_...
File extensions/browser/api/web_request/web_request_api.cc (right):

https://codereview.chromium.org/2484353002/diff/1/extensions/browser/api/web_...
extensions/browser/api/web_request/web_request_api.cc:971: if (!client) {
On 2016/11/09 00:10:11, lazyboy wrote:
> I'd add a comment here saying |client| could be null during shutdown.

Done.

[krasin1, 2016-11-09 00:36:16]

The CQ bit was checked by krasin@chromium.org

[krasin1, 2016-11-09 00:36:16]

The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2484353002/#ps40001
(title: "Add ||")

[commit-bot: I haz the power, 2016-11-09 00:36:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 02:17:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-09 02:21:45]

Description was changed from

==========
Unflake AppViewTest.TestAppViewGoodDataShouldSucceed under UBSan Vptr.

Sometimes (when Chromium is being deleted), ExtensionsBrowserClient::Get() could
return NULL.
This fix avoids calling a virtual method on a null pointer, deflaking the test
under UBSan Vptr. See the bug attached for more details.

BUG=663552
==========

to

==========
Unflake AppViewTest.TestAppViewGoodDataShouldSucceed under UBSan Vptr.

Sometimes (when Chromium is being deleted), ExtensionsBrowserClient::Get() could
return NULL.
This fix avoids calling a virtual method on a null pointer, deflaking the test
under UBSan Vptr. See the bug attached for more details.

BUG=663552

Committed: https://crrev.com/b72974798e11b6cffe236f746c3a778ddeba57b5
Cr-Commit-Position: refs/heads/master@{#430830}
==========

[commit-bot: I haz the power, 2016-11-09 02:21:46]

Patchset 3 (id:??) landed as
https://crrev.com/b72974798e11b6cffe236f746c3a778ddeba57b5
Cr-Commit-Position: refs/heads/master@{#430830}