Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5973)

Unified Diff: chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc

Issue 2484323002: Add a NetworkQualityEstimator to TestURLRequestContext. (Closed)
Patch Set: Fix tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_transaction_test_util.h » ('j') | net/nqe/network_quality_estimator_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc
diff --git a/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc b/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc
index dcbbea6ccc7763c4a4377ac3947ff8356db3724d..4a97e268f6ed072b50e61f08836f51832a8dfda0 100644
--- a/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc
+++ b/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc
@@ -322,9 +322,9 @@ class ChromeExpectCTReporterWaitTest : public ::testing::Test {
}
private:
+ content::TestBrowserThreadBundle thread_bundle_;
TestExpectCTNetworkDelegate network_delegate_;
net::TestURLRequestContext context_;
- content::TestBrowserThreadBundle thread_bundle_;
DISALLOW_COPY_AND_ASSIGN(ChromeExpectCTReporterWaitTest);
};
@@ -337,6 +337,8 @@ TEST(ChromeExpectCTReporterTest, FeatureDisabled) {
histograms.ExpectTotalCount(kSendHistogramName, 0);
TestCertificateReportSender* sender = new TestCertificateReportSender();
+ content::TestBrowserThreadBundle thread_bundle(
+ content::TestBrowserThreadBundle::IO_MAINLOOP);
mmenke 2016/11/14 20:16:38 These are because the NQE expects a MessageLoop on
net::TestURLRequestContext context;
ChromeExpectCTReporter reporter(&context);
reporter.report_sender_.reset(sender);
@@ -368,6 +370,8 @@ TEST(ChromeExpectCTReporterTest, EmptyReportURI) {
scoped_feature_list.InitAndEnableFeature(features::kExpectCTReporting);
TestCertificateReportSender* sender = new TestCertificateReportSender();
+ content::TestBrowserThreadBundle thread_bundle(
+ content::TestBrowserThreadBundle::IO_MAINLOOP);
net::TestURLRequestContext context;
ChromeExpectCTReporter reporter(&context);
reporter.report_sender_.reset(sender);
@@ -422,6 +426,8 @@ TEST(ChromeExpectCTReporterTest, SendReport) {
scoped_feature_list.InitAndEnableFeature(features::kExpectCTReporting);
TestCertificateReportSender* sender = new TestCertificateReportSender();
+ content::TestBrowserThreadBundle thread_bundle(
+ content::TestBrowserThreadBundle::IO_MAINLOOP);
net::TestURLRequestContext context;
ChromeExpectCTReporter reporter(&context);
reporter.report_sender_.reset(sender);
« no previous file with comments | « no previous file | net/http/http_transaction_test_util.h » ('j') | net/nqe/network_quality_estimator_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698