Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2438)

Unified Diff: chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc

Issue 2484323002: Add a NetworkQualityEstimator to TestURLRequestContext. (Closed)
Patch Set: Update comments, fix Android tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/android/url_request_content_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc
diff --git a/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc b/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc
index dcbbea6ccc7763c4a4377ac3947ff8356db3724d..12f9b6c8275cdfb0f72ffc5bf0adfdbe0905bce5 100644
--- a/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc
+++ b/chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc
@@ -295,8 +295,8 @@ class TestExpectCTNetworkDelegate : public net::NetworkDelegateImpl {
class ChromeExpectCTReporterWaitTest : public ::testing::Test {
public:
ChromeExpectCTReporterWaitTest()
- : context_(true),
- thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP) {
+ : thread_bundle_(content::TestBrowserThreadBundle::IO_MAINLOOP),
+ context_(true) {
context_.set_network_delegate(&network_delegate_);
context_.Init();
}
@@ -322,9 +322,9 @@ class ChromeExpectCTReporterWaitTest : public ::testing::Test {
}
private:
+ content::TestBrowserThreadBundle thread_bundle_;
TestExpectCTNetworkDelegate network_delegate_;
net::TestURLRequestContext context_;
- content::TestBrowserThreadBundle thread_bundle_;
DISALLOW_COPY_AND_ASSIGN(ChromeExpectCTReporterWaitTest);
};
@@ -337,6 +337,8 @@ TEST(ChromeExpectCTReporterTest, FeatureDisabled) {
histograms.ExpectTotalCount(kSendHistogramName, 0);
TestCertificateReportSender* sender = new TestCertificateReportSender();
+ content::TestBrowserThreadBundle thread_bundle(
+ content::TestBrowserThreadBundle::IO_MAINLOOP);
net::TestURLRequestContext context;
ChromeExpectCTReporter reporter(&context);
reporter.report_sender_.reset(sender);
@@ -368,6 +370,8 @@ TEST(ChromeExpectCTReporterTest, EmptyReportURI) {
scoped_feature_list.InitAndEnableFeature(features::kExpectCTReporting);
TestCertificateReportSender* sender = new TestCertificateReportSender();
+ content::TestBrowserThreadBundle thread_bundle(
+ content::TestBrowserThreadBundle::IO_MAINLOOP);
net::TestURLRequestContext context;
ChromeExpectCTReporter reporter(&context);
reporter.report_sender_.reset(sender);
@@ -422,6 +426,8 @@ TEST(ChromeExpectCTReporterTest, SendReport) {
scoped_feature_list.InitAndEnableFeature(features::kExpectCTReporting);
TestCertificateReportSender* sender = new TestCertificateReportSender();
+ content::TestBrowserThreadBundle thread_bundle(
+ content::TestBrowserThreadBundle::IO_MAINLOOP);
net::TestURLRequestContext context;
ChromeExpectCTReporter reporter(&context);
reporter.report_sender_.reset(sender);
« no previous file with comments | « no previous file | content/browser/android/url_request_content_job_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698