chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java - Issue 2484293003: Use only renderer driven offsets for fullscreen state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java

Issue 2484293003: Use only renderer driven offsets for fullscreen state. (Closed)

Patch Set: Partially disable testControlsShownOnUnresponsiveRenderer due to timing issues with renderer logic … Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/TabStateBrowserControlsVisibilityDelegate.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java

index 28e7d3ce934e0fbdd5018a092f8ad9e428fe9c6f..c14a41635eda899f8be217492ddc0ed42d782744 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java

@@ -29,7 +29,7 @@ import org.chromium.chrome.R;

import org.chromium.chrome.browser.appmenu.AppMenuButtonHelper;

import org.chromium.chrome.browser.compositor.Invalidator;

import org.chromium.chrome.browser.compositor.layouts.LayoutUpdateHost;

-import org.chromium.chrome.browser.fullscreen.FullscreenManager;

+import org.chromium.chrome.browser.fullscreen.BrowserStateBrowserControlsVisibilityDelegate;

import org.chromium.chrome.browser.ntp.NewTabPage;

import org.chromium.chrome.browser.omaha.UpdateMenuItemHelper;

import org.chromium.chrome.browser.omnibox.LocationBar;

@@ -325,9 +325,10 @@ abstract class ToolbarLayout extends FrameLayout implements Toolbar {

public void destroy() { }

/**

- * Sets the FullscreenManager, which controls when the toolbar is shown.

+ * Sets the delegate to handle visibility of browser controls.

- public void setFullscreenManager(FullscreenManager manager) { }

+ public void setBrowserControlsVisibilityDelegate(

+ BrowserStateBrowserControlsVisibilityDelegate controlsVisibilityDelegate) { }

/**

* Sets the OnClickListener that will be notified when the TabSwitcher button is pressed.