chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java - Issue 2484293003: Use only renderer driven offsets for fullscreen state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java

Issue 2484293003: Use only renderer driven offsets for fullscreen state. (Closed)

Patch Set: Partially disable testControlsShownOnUnresponsiveRenderer due to timing issues with renderer logic … Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromeTablet.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java

index 2c8f08e0052d7eab1dde572bb606a042b0fbdfe5..a402963f9fcf1173d267d387c6045a4f7808e428 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java

@@ -459,13 +459,15 @@ public abstract class LayoutManager implements LayoutUpdateHost, LayoutProvider,

ChromeFullscreenManager fullscreenManager = mHost.getFullscreenManager();

if (fullscreenManager != null) {

// Release any old fullscreen token we were holding.

- fullscreenManager.hideControlsPersistent(mFullscreenToken);

+ fullscreenManager.getBrowserVisibilityDelegate().hideControlsPersistent(

+ mFullscreenToken);

mFullscreenToken = FullscreenManager.INVALID_TOKEN;

// Grab a new fullscreen token if this layout can't be in fullscreen.

final int flags = getActiveLayout().getSizingFlags();

if ((flags & SizingFlags.ALLOW_TOOLBAR_HIDE) == 0) {

- mFullscreenToken = fullscreenManager.showControlsPersistent();

+ mFullscreenToken =

+ fullscreenManager.getBrowserVisibilityDelegate().showControlsPersistent();

}

// Hide the toolbar immediately if the layout wants it gone quickly.