Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2484283005: Expose Thread::using_external_message_loop() to subclasses. (Closed)

Created:
4 years, 1 month ago by gab
Modified:
4 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose Thread::using_external_message_loop() to subclasses. Extracted from https://codereview.chromium.org/2464233002/#ps260001 as I flip flop back and forth between it and precursor CLs and having a change in thread.h forces painful rebuilds... BUG=653916 Committed: https://crrev.com/f7f153ec850decdcc9bbd2f874c7b8e219bb321d Cr-Commit-Position: refs/heads/master@{#430960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M base/threading/thread.h View 2 chunks +7 lines, -1 line 0 comments Download
M base/threading/thread_unittest.cc View 3 chunks +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
gab
Mark PTAL, thanks!
4 years, 1 month ago (2016-11-09 16:17:21 UTC) #4
Mark Mentovai
LGTM
4 years, 1 month ago (2016-11-09 16:55:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484283005/1
4 years, 1 month ago (2016-11-09 16:57:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 17:30:05 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 17:32:37 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7f153ec850decdcc9bbd2f874c7b8e219bb321d
Cr-Commit-Position: refs/heads/master@{#430960}

Powered by Google App Engine
This is Rietveld 408576698