[DevTools] added BreakpointManager.possibleBreakpoints method

third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 231 matching lines @@
     /**
      * @this {WebInspector.JavaScriptSourceFrame}
      */
     function populate(resolve, reject) {
       var uiLocation = new WebInspector.UILocation(this.uiSourceCode(), lineNumber, 0);
       this._scriptsPanel.appendUILocationItems(contextMenu, uiLocation);
       var breakpoints = this._breakpointManager.findBreakpoints(this.uiSourceCode(), lineNumber);
       if (!breakpoints.length) {
         // This row doesn't have a breakpoint: We want to show Add Breakpoint and Add and Edit Breakpoint.
         contextMenu.appendItem(
-            WebInspector.UIString('Add breakpoint'), this._createNewBreakpoint.bind(this, lineNumber, 0, '', true));
+            WebInspector.UIString('Add breakpoint'), this._createNewBreakpoint.bind(this, lineNumber, '', true));
         contextMenu.appendItem(
             WebInspector.UIString('Add conditional breakpoint…'), this._editBreakpointCondition.bind(this, lineNumber));
         contextMenu.appendItem(
             WebInspector.UIString('Never pause here'),
-            this._createNewBreakpoint.bind(this, lineNumber, 0, 'false', true));
+            this._createNewBreakpoint.bind(this, lineNumber, 'false', true));
       } else {
         var breakpoint = breakpoints[0];
 
         // This row has a breakpoint, we want to show edit and remove breakpoint, and either disable or enable.
         contextMenu.appendItem(WebInspector.UIString('Remove breakpoint'), breakpoint.remove.bind(breakpoint));
         contextMenu.appendItem(
             WebInspector.UIString('Edit breakpoint…'),
             this._editBreakpointCondition.bind(this, lineNumber, breakpoint));
         if (breakpoint.enabled())
           contextMenu.appendItem(
@@ skipping 330 matching lines @@
     function finishEditing(committed, element, newText) {
       this.textEditor.removeDecoration(this._conditionElement, lineNumber);
       delete this._conditionEditorElement;
       delete this._conditionElement;
       if (!committed)
         return;
 
       if (breakpoint)
         breakpoint.setCondition(newText);
       else
-        this._createNewBreakpoint(lineNumber, 0, newText, true);
+        this._createNewBreakpoint(lineNumber, newText, true);
     }
 
     var config = new WebInspector.InplaceEditor.Config(finishEditing.bind(this, true), finishEditing.bind(this, false));
     WebInspector.InplaceEditor.startEditing(this._conditionEditorElement, config);
     this._conditionEditorElement.value = breakpoint ? breakpoint.condition() : '';
     this._conditionEditorElement.select();
   }
 
   _createConditionElement(lineNumber) {
     var conditionElement = createElementWithClass('div', 'source-frame-breakpoint-condition');
@@ skipping 386 matching lines @@
    * @param {boolean} onlyDisable
    */
   _toggleBreakpoint(lineNumber, onlyDisable) {
     var breakpoints = this._breakpointManager.findBreakpoints(this.uiSourceCode(), lineNumber);
     if (breakpoints.length) {
       if (onlyDisable)
         breakpoints[0].setEnabled(!breakpoints[0].enabled());
       else
         breakpoints[0].remove();
     } else
-      this._createNewBreakpoint(lineNumber, 0, '', true);
+      this._createNewBreakpoint(lineNumber, '', true);
   }
 
   /**
    * @param {number} lineNumber
-   * @param {number} columnNumber
    * @param {string} condition
    * @param {boolean} enabled
    */
-  _createNewBreakpoint(lineNumber, columnNumber, condition, enabled) {
-    this._setBreakpoint(lineNumber, columnNumber, condition, enabled);
-    WebInspector.userMetrics.actionTaken(WebInspector.UserMetrics.Action.ScriptsBreakpointSet);
+  _createNewBreakpoint(lineNumber, condition, enabled) {
+    const linesToCheck = 5;
+    var promise = Promise.resolve();
+    for (let i = 0; i < linesToCheck; ++i)

[dgozman, 2016/11/09 20:44:03]

let! Oh my!

[kozy, 2016/11/10 03:17:36]

Done.

+      promise = promise.then(locations => locations ? locations : findPossibleBreakpoints.call(this, lineNumber + i));

[dgozman, 2016/11/09 20:44:03]

From my tests on DevTools engineers;
- one failed to understand this;
- another one understood it in 90 seconds;
- one knew in advance what's happening.
Compiler failed to understand this as well.
I think we should make this more explicit.

[kozy, 2016/11/10 03:17:36]

Done.

+    promise.then(setBreakpoint.bind(this));
+
+    /**
+     * @this {!WebInspector.JavaScriptSourceFrame}
+     * @param {number} lineNumber
+     * @return {!Promise<!Array<!WebInspector.UILocation>>}

[dgozman, 2016/11/09 20:44:03]

?Array

[kozy, 2016/11/10 03:17:36]

Done.

+     */
+    function findPossibleBreakpoints(lineNumber) {
+      const maxLengthToCheck = 1024;
+      if (this._textEditor.line(lineNumber).length >= maxLengthToCheck)
+        return Promise.resolve([]);
+      return this._breakpointManager.possibleBreakpoints(this.uiSourceCode(), new WebInspector.TextRange(lineNumber, 0, lineNumber + 1, 0))
+          .then(locations => locations.length ? locations : null);
+    }
+
+    /**
+     * @this {!WebInspector.JavaScriptSourceFrame}
+     * @param {!Array<!WebInspector.UILocation>} locations

[dgozman, 2016/11/09 20:44:03]

?Array

[kozy, 2016/11/10 03:17:36]

Done.

+     */
+    function setBreakpoint(locations) {
+      if (!locations || !locations.length)
+        this._setBreakpoint(lineNumber, 0, condition, enabled);
+      else
+        this._setBreakpoint(locations[0].lineNumber, locations[0].columnNumber, condition, enabled);
+      WebInspector.userMetrics.actionTaken(WebInspector.UserMetrics.Action.ScriptsBreakpointSet);
+    }
   }
 
   toggleBreakpointOnCurrentLine() {
     if (this._muted)
       return;
 
     var selection = this.textEditor.selection();
     if (!selection)
       return;
     this._toggleBreakpoint(selection.startLine, false);
@@ skipping 26 matching lines @@
         WebInspector.UISourceCode.Events.WorkingCopyChanged, this._workingCopyChanged, this);
     this.uiSourceCode().removeEventListener(
         WebInspector.UISourceCode.Events.WorkingCopyCommitted, this._workingCopyCommitted, this);
     this.uiSourceCode().removeEventListener(
         WebInspector.UISourceCode.Events.TitleChanged, this._showBlackboxInfobarIfNeeded, this);
     WebInspector.moduleSetting('skipStackFramesPattern').removeChangeListener(this._showBlackboxInfobarIfNeeded, this);
     WebInspector.moduleSetting('skipContentScripts').removeChangeListener(this._showBlackboxInfobarIfNeeded, this);
     super.dispose();
   }
 };