Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 2484283002: [arm] Fix custom addition in MacroAssembler::[Fast]Allocate (Closed)

Created:
4 years, 1 month ago by Jakob Kummerow
Modified:
4 years, 1 month ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Fix custom addition in MacroAssembler::[Fast]Allocate Don't rely on carry flags you didn't set yourself. BUG=chromium:663402 Committed: https://crrev.com/87332fdf677f1b53f71be7c05d025a285e5a5c73 Cr-Commit-Position: refs/heads/master@{#40848}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -6 lines) Patch
M src/arm/macro-assembler-arm.cc View 4 chunks +2 lines, -6 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-663402.js View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jakob Kummerow
PTAL.
4 years, 1 month ago (2016-11-08 17:50:42 UTC) #2
Michael Lippautz
lgtm, thanks a lot!
4 years, 1 month ago (2016-11-08 17:52:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484283002/1
4 years, 1 month ago (2016-11-08 17:53:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 18:19:04 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:26:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87332fdf677f1b53f71be7c05d025a285e5a5c73
Cr-Commit-Position: refs/heads/master@{#40848}

Powered by Google App Engine
This is Rietveld 408576698