[Presentation API] (1-UA) fire PresentationConnection onterminate event if receiver page gets destr…

content/browser/presentation/presentation_service_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/presentation/presentation_service_impl.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <algorithm>
 #include <utility>
@@ skipping 559 matching lines @@
   Reset();
   delete this;
 }
 
 void PresentationServiceImpl::Reset() {
   DVLOG(2) << "PresentationServiceImpl::Reset";
 
   if (auto delegate = GetPresentationServiceDelegate())
     delegate->Reset(render_process_id_, render_frame_id_);
 
+  if (receiver_delegate_) {

[imcheng, 2016/11/28 22:12:00]

If the receiver frame is already being destroyed then isn't this unnecessary?

[zhaobin, 2017/02/16 00:42:30]

This function is called before destroying PresentationDispatcher and
PresentationReceiver. Adding state change here could invoke receiver
connection's onterminate handler...

[imcheng, 2017/02/24 19:20:33]

I see. Note that Reset() also gets called on navigation.
- In that case does the offscreen tab capture stop?
- Does the controller side get notified of state change?
- Should we allow the offscreen tab to navigate at all?

[imcheng, 2017/02/24 19:20:33]

It feels like we should be able to observe for this case in the renderer /
PresentationDispatcher and notify the connection object(s) directly without
going through Mojo.

[zhaobin, 2017/02/25 01:31:03]

Move state change to PresentationDispatcher.

Controller will get notified by MRP.

Setting window.location.href on receiver page does not work. There seems to be
some mechanism disable navigation from offscreen_tab.

[mark a. foltz, 2017/02/25 01:43:12]

The offscreen tab should be closed if it attempts top-level navigation.  (I can
check the spec for the exact wording)
No.  However on close reading of the spec we don't have a flag blocking this. 
Filed https://github.com/w3c/presentation-api/issues/414 to update the spec.

+    PresentationSessionInfo dummy_session(GURL("fake_url"), "fake_id", true);
+    OnConnectionStateChanged(dummy_session,
+                             PresentationConnectionStateChangeInfo(
+                                 PRESENTATION_CONNECTION_STATE_TERMINATED));
+  }
+
   default_presentation_urls_.clear();
 
   screen_availability_listeners_.clear();
 
   start_session_request_id_ = kInvalidRequestSessionId;
   pending_start_session_cb_.reset();
 
   pending_join_session_cbs_.clear();
 
   if (on_session_messages_callback_.get()) {
@@ skipping 67 matching lines @@
 
 void PresentationServiceImpl::NewSessionCallbackWrapper::Run(
     blink::mojom::PresentationSessionInfoPtr session,
     blink::mojom::PresentationErrorPtr error) {
   DCHECK(!callback_.is_null());
   callback_.Run(std::move(session), std::move(error));
   callback_.Reset();
 }
 
 }  // namespace content