Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2484273002: Move the matrix stage of SkLinearBitmapPipeline over to using SkSmallAllocator. (Closed)

Created:
4 years, 1 month ago by herb_g
Modified:
4 years, 1 month ago
Reviewers:
mtklein, mtklein_C
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move the matrix stage of SkLinearBitmapPipeline over to using SkSmallAllocator. The rest of the stages will follow. When all stages are completed, this should significantly reduce stack use in the typical case. This a step in removing the baroque stage system and moving towards a SkRasterPipeline stage system. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2484273002 Committed: https://skia.googlesource.com/skia/+/be42c994b41a6d99b4bbf370aa1634350c773219

Patch Set 1 #

Patch Set 2 : Fix dangling ref problem #

Patch Set 3 : rebase on new SkSmallAllocator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -48 lines) Patch
M src/core/SkLinearBitmapPipeline.h View 1 2 chunks +11 lines, -2 lines 0 comments Download
M src/core/SkLinearBitmapPipeline.cpp View 1 5 chunks +57 lines, -38 lines 0 comments Download
M src/core/SkLinearBitmapPipeline_matrix.h View 6 chunks +8 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 25 (17 generated)
herb_g
Fix dangling ref problem
4 years, 1 month ago (2016-11-08 20:34:52 UTC) #3
herb_g
4 years, 1 month ago (2016-11-08 22:23:40 UTC) #9
herb_g
4 years, 1 month ago (2016-11-09 15:32:08 UTC) #10
herb_g
rebase on new SkSmallAllocator
4 years, 1 month ago (2016-11-09 19:28:51 UTC) #12
mtklein_C
lgtm
4 years, 1 month ago (2016-11-10 14:20:06 UTC) #18
commit-bot: I haz the power
This CL has an open dependency (Issue 2488523003 Patch 60001). Please resolve the dependency and ...
4 years, 1 month ago (2016-11-14 20:54:50 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484273002/40001
4 years, 1 month ago (2016-11-15 21:22:55 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 22:07:16 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/be42c994b41a6d99b4bbf370aa1634350c773219

Powered by Google App Engine
This is Rietveld 408576698