Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Issue 2484263005: Revert of Revert "Revert of Moving gRPC support interfaces out of cronet and into a new component. (Closed)

Created:
4 years, 1 month ago by Dirk Pranke
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blundell+watchlist_chromium.org, cbentzel+watch_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert "Revert of Moving gRPC support interfaces out of cronet and into a new component. (patchset … (patchset #5 id:100001 of https://codereview.chromium.org/2470923002/ ) Reason for revert: Looks like this broke component_unittests on Android and Windows: https://build.chromium.org/p/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/6152 https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/59755 so I'm going to revert this. Sorry! Original issue's description: > Reland refactor of gRPC. Previous CL was reverted because it used a fixed port for testing, which was sometimes occupied. The test now uses dynamically bound ports for Cronet as well as the grpc_support unittest. > > Revert "Revert of Moving gRPC support interfaces out of cronet and into a new component. (patchset #67 id:1300001 of https://codereview.chromium.org/2273403003/ )" > > This reverts commit 3b72ebe609598fa876ddd2af0b61636a225486c1. > > TBR=blundell@chromium.org > BUG=650462 > > Committed: https://crrev.com/47cd6404f5dbcf436a4dd0e1685498da2ec3f4fe > Cr-Commit-Position: refs/heads/master@{#430995} TBR=mef@chromium.org,gcasto@chromium.org NOPRESUBMIT=true BUG=650462 Committed: https://crrev.com/f42bc4c56bd255e293109de16b8d19b7adcdc889 Cr-Commit-Position: refs/heads/master@{#431058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2094 lines, -2404 lines) Patch
M components/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/cronet/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/cronet/ios/BUILD.gn View 4 chunks +11 lines, -14 lines 0 comments Download
M components/cronet/ios/Cronet.h View 3 chunks +4 lines, -6 lines 0 comments Download
M components/cronet/ios/Cronet.mm View 4 chunks +9 lines, -8 lines 0 comments Download
A components/cronet/ios/cronet_bidirectional_stream.h View 1 chunk +232 lines, -0 lines 0 comments Download
A components/cronet/ios/cronet_bidirectional_stream.cc View 1 chunk +390 lines, -0 lines 0 comments Download
A components/cronet/ios/cronet_c_for_grpc.h View 1 chunk +243 lines, -0 lines 0 comments Download
A components/cronet/ios/cronet_c_for_grpc.cc View 1 chunk +290 lines, -0 lines 0 comments Download
M components/cronet/ios/cronet_environment.h View 3 chunks +12 lines, -13 lines 0 comments Download
M components/cronet/ios/cronet_environment.cc View 3 chunks +5 lines, -18 lines 0 comments Download
M components/cronet/ios/test/BUILD.gn View 2 chunks +3 lines, -5 lines 0 comments Download
A components/cronet/ios/test/cronet_bidirectional_stream_test.mm View 1 chunk +709 lines, -0 lines 0 comments Download
M components/cronet/ios/test/cronet_http_test.mm View 4 chunks +18 lines, -19 lines 0 comments Download
M components/cronet/ios/test/cronet_test_runner.mm View 1 chunk +0 lines, -4 lines 0 comments Download
D components/cronet/ios/test/get_stream_engine.mm View 1 chunk +0 lines, -18 lines 0 comments Download
A components/cronet/ios/test/quic_test_server.h View 1 chunk +32 lines, -0 lines 0 comments Download
A components/cronet/ios/test/quic_test_server.cc View 1 chunk +136 lines, -0 lines 0 comments Download
D components/cronet/ios/test/start_cronet.h View 1 chunk +0 lines, -11 lines 0 comments Download
D components/cronet/ios/test/start_cronet.mm View 1 chunk +0 lines, -35 lines 0 comments Download
D components/grpc_support/BUILD.gn View 1 chunk +0 lines, -33 lines 0 comments Download
D components/grpc_support/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D components/grpc_support/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D components/grpc_support/README.md View 1 chunk +0 lines, -14 lines 0 comments Download
D components/grpc_support/bidirectional_stream.h View 1 chunk +0 lines, -236 lines 0 comments Download
D components/grpc_support/bidirectional_stream.cc View 1 chunk +0 lines, -401 lines 0 comments Download
D components/grpc_support/bidirectional_stream_c.cc View 1 chunk +0 lines, -285 lines 0 comments Download
D components/grpc_support/bidirectional_stream_unittest.cc View 1 chunk +0 lines, -656 lines 0 comments Download
D components/grpc_support/include/DEPS View 1 chunk +0 lines, -8 lines 0 comments Download
D components/grpc_support/include/bidirectional_stream_c.h View 1 chunk +0 lines, -246 lines 0 comments Download
D components/grpc_support/include/headers.gni View 1 chunk +0 lines, -2 lines 0 comments Download
D components/grpc_support/test/BUILD.gn View 1 chunk +0 lines, -42 lines 0 comments Download
D components/grpc_support/test/get_stream_engine.h View 1 chunk +0 lines, -19 lines 0 comments Download
D components/grpc_support/test/get_stream_engine.cc View 1 chunk +0 lines, -130 lines 0 comments Download
D components/grpc_support/test/quic_test_server.h View 1 chunk +0 lines, -34 lines 0 comments Download
D components/grpc_support/test/quic_test_server.cc View 1 chunk +0 lines, -139 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Dirk Pranke
Created Revert of Revert "Revert of Moving gRPC support interfaces out of cronet and into ...
4 years, 1 month ago (2016-11-09 19:48:23 UTC) #2
Lei Zhang
Is this going to land?
4 years, 1 month ago (2016-11-09 21:36:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2484263005/1
4 years, 1 month ago (2016-11-09 22:36:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 22:39:01 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 22:53:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f42bc4c56bd255e293109de16b8d19b7adcdc889
Cr-Commit-Position: refs/heads/master@{#431058}

Powered by Google App Engine
This is Rietveld 408576698