Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2484263002:
Hide scrollbars for the body of the sign-in dialogs. (Closed)
DescriptionHide scrollbars for the body of the sign-in dialogs.
This CL hides the scrollbars for the body in all sign-in WebUI dialogs
as all sign-in dialogs are resized when the document is loaded.
BUG=627411
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/0b510d0aebff97037598a470ff8f10901cc6187b
Cr-Commit-Position: refs/heads/master@{#431283}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Nits #Messages
Total messages: 19 (8 generated)
Description was changed from ========== Hide scrollbars for the body of the sign-in dialogs. This CL hides the scrollbars for the body in all sign-in WebUI dialogs as all sign-in dialogs are resized when the document is loaded. BUG=627411 ========== to ========== Hide scrollbars for the body of the sign-in dialogs. This CL hides the scrollbars for the body in all sign-in WebUI dialogs as all sign-in dialogs are resized when the document is loaded. BUG=627411 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
msarda@chromium.org changed reviewers: + anthonyvd@chromium.org
Please take a look. Another solution we may have if you want us to keep the scrollbars, would be to resize the height of the dialog to document.body.scrollHeight+15.
On 2016/11/08 at 15:47:33, msarda wrote: > Please take a look. > > Another solution we may have if you want us to keep the scrollbars, would be to resize the height of the dialog to document.body.scrollHeight+15. This solution makes more sense I think. This is what I would have gone for if I ever was able to repro and test it. lgtm
The CQ bit was checked by msarda@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
msarda@chromium.org changed reviewers: + xiyuan@chromium.org
xiyuan@chromium.org: Please do an owners review for this file.
https://codereview.chromium.org/2484263002/diff/1/chrome/browser/resources/si... File chrome/browser/resources/signin/signin_shared_css.html (right): https://codereview.chromium.org/2484263002/diff/1/chrome/browser/resources/si... chrome/browser/resources/signin/signin_shared_css.html:15: overflow: hidden; nit: move before 'padding' to keep the list alpha sorted. https://codereview.chromium.org/2484263002/diff/1/chrome/browser/resources/si... chrome/browser/resources/signin/signin_shared_css.html:43: width: 448px; nit: move it back to keep the list sorted.
https://codereview.chromium.org/2484263002/diff/1/chrome/browser/resources/si... File chrome/browser/resources/signin/signin_shared_css.html (right): https://codereview.chromium.org/2484263002/diff/1/chrome/browser/resources/si... chrome/browser/resources/signin/signin_shared_css.html:15: overflow: hidden; On 2016/11/09 18:10:32, xiyuan wrote: > nit: move before 'padding' to keep the list alpha sorted. Done. https://codereview.chromium.org/2484263002/diff/1/chrome/browser/resources/si... chrome/browser/resources/signin/signin_shared_css.html:43: width: 448px; On 2016/11/09 18:10:32, xiyuan wrote: > nit: move it back to keep the list sorted. Done.
lgtm
The CQ bit was checked by msarda@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from anthonyvd@chromium.org Link to the patchset: https://codereview.chromium.org/2484263002/#ps20001 (title: "Nits")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Hide scrollbars for the body of the sign-in dialogs. This CL hides the scrollbars for the body in all sign-in WebUI dialogs as all sign-in dialogs are resized when the document is loaded. BUG=627411 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Hide scrollbars for the body of the sign-in dialogs. This CL hides the scrollbars for the body in all sign-in WebUI dialogs as all sign-in dialogs are resized when the document is loaded. BUG=627411 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0b510d0aebff97037598a470ff8f10901cc6187b Cr-Commit-Position: refs/heads/master@{#431283} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/0b510d0aebff97037598a470ff8f10901cc6187b Cr-Commit-Position: refs/heads/master@{#431283} |
