components/offline_pages/stub_offline_page_model.h - Issue 2484223005: Store original request URL in offline page metadata table

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/stub_offline_page_model.h

Issue 2484223005: Store original request URL in offline page metadata table (Closed)

Patch Set: Address feedback Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/stub_offline_page_model.h

diff --git a/components/offline_pages/stub_offline_page_model.h b/components/offline_pages/stub_offline_page_model.h

index 55f0c0177d602bbc7ee7d149e28688ce5ea9e802..74a2696d94751b21126c91a1219469f279eb8b3b 100644

--- a/components/offline_pages/stub_offline_page_model.h

+++ b/components/offline_pages/stub_offline_page_model.h

@@ -24,9 +24,7 @@ class StubOfflinePageModel : public OfflinePageModel, public KeyedService {

void AddObserver(Observer* observer) override;

void RemoveObserver(Observer* observer) override;

- void SavePage(const GURL& url,

- const ClientId& client_id,

- int64_t proposed_offline_id,

+ void SavePage(const SavePageParams& save_page_params,

std::unique_ptr<OfflinePageArchiver> archiver,

const SavePageCallback& callback) override;

void MarkPageAccessed(int64_t offline_id) override;